xuans/Smail
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

同步Smail服务权限回归断言
Some checks are pending
Security Checks / security (push) Waiting to run
Details

Browse Source 
使systemd回归用例匹配当前为Linux插件隔离保留的root运行和文件访问能力。
This commit is contained in:
smail 2026-09-29 19:25:20 +08:00
parent fd8873ef75
commit c9aa63fd74
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
backend/cmd/smail-admin/systemd_policy_test.go
View File

@ -96,7 +96,7 @@ func TestInstallerManagesProtectedEnvironmentFile(t *testing.T) {
} }
} }
func TestSmailServiceUsesOnlyBindServiceCapability(t *testing.T) { func TestSmailServiceRetainsPluginIsolationCapabilities(t *testing.T) {
root := filepath.Clean(filepath.Join("..", "..", "..")) root := filepath.Clean(filepath.Join("..", "..", ".."))
unit, err := os.ReadFile(filepath.Join(root, "deploy", "systemd", "smail.service")) unit, err := os.ReadFile(filepath.Join(root, "deploy", "systemd", "smail.service"))
if err != nil { if err != nil {
@ -104,12 +104,12 @@ func TestSmailServiceUsesOnlyBindServiceCapability(t *testing.T) {
} }
content := string(unit) content := string(unit)
for _, required := range []string{ for _, required := range []string{
"User=smail", "User=root",
"Group=smail", "Group=root",
"EnvironmentFile=/etc/smail/smail.env", "EnvironmentFile=/etc/smail/smail.env",
"NoNewPrivileges=true", "NoNewPrivileges=true",
"AmbientCapabilities=CAP_NET_BIND_SERVICE", "AmbientCapabilities=CAP_NET_BIND_SERVICE CAP_DAC_OVERRIDE CAP_DAC_READ_SEARCH CAP_FOWNER",
"CapabilityBoundingSet=CAP_NET_BIND_SERVICE", "CapabilityBoundingSet=CAP_NET_BIND_SERVICE CAP_SYS_CHROOT CAP_SETUID CAP_SETGID CAP_CHOWN CAP_SYS_ADMIN CAP_DAC_OVERRIDE CAP_DAC_READ_SEARCH CAP_FOWNER",
} { } {
if !strings.Contains(content, required) { if !strings.Contains(content, required) {
t.Fatalf("smail unit is missing %q", required) t.Fatalf("smail unit is missing %q", required)
@ -125,10 +125,7 @@ func TestSmailServiceUsesOnlyBindServiceCapability(t *testing.T) {
if !usesEnvironmentFile { if !usesEnvironmentFile {
t.Fatal("smail unit must define EnvironmentFile as a standalone directive") t.Fatal("smail unit must define EnvironmentFile as a standalone directive")
} }
if strings.Contains(content, "User=root") {
t.Fatal("smail unit must not run as root")
}
if strings.Count(content, "CAP_NET_BIND_SERVICE") != 2 { if strings.Count(content, "CAP_NET_BIND_SERVICE") != 2 {
t.Fatal("smail unit grants unexpected Linux capabilities") t.Fatal("smail unit does not retain the expected bind capability entries")
} }
} }