保存日志权限分页与归档并发修正,继续运行验收
Security Checks / security (push) Waiting to run

This commit is contained in:
xuans committed 2026-09-08 22:44:21 +08:00
1 parent 5faadcd6eb
commit b77b272a5e
16 files changed
+280 -40

No files matched your search

+77
View File
@@ -0,0 +1,77 @@
package controllers
import (
"context"
"database/sql"
"encoding/json"
"net/http/httptest"
"path/filepath"
"testing"
"time"
"git.pcux.cn/xuans/Smail/db/migration"
"git.pcux.cn/xuans/Smail/dto/response"
"git.pcux.cn/xuans/Smail/services/access"
"git.pcux.cn/xuans/Smail/services/logstore"
appcontext "git.pcux.cn/xuans/Smail/utils/context"
_ "modernc.org/sqlite"
)
func TestLogsAPIRejectsUnscopedAccessAndValidatesQueries(t *testing.T) {
database, err := sql.Open("sqlite", filepath.Join(t.TempDir(), "logs.db"))
if err != nil {
t.Fatal(err)
}
defer database.Close()
// 与正式 SQLite 连接池一致,避免测试自行引入多写连接锁冲突。
database.SetMaxOpenConns(1)
items := migration.DefaultMigrations()
for _, statement := range items[len(items)-1].StatementsFor(migration.DialectSQLite) {
if _, err := database.Exec(statement); err != nil {
t.Fatal(err)
}
}
store, err := logstore.New(database, migration.DialectSQLite)
if err != nil {
t.Fatal(err)
}
runtime := logstore.Start(store)
defer runtime.Stop()
if err := store.Write(context.Background(), logstore.Entry{Kind: "operation", CreatedAt: time.Now(), ActorID: "42", Action: "probe", Result: "success", Payload: []byte(`{}`)}); err != nil {
t.Fatal(err)
}
call := func(role access.Role, query string) response.Response {
t.Helper()
request := httptest.NewRequest("GET", "/api/v1/logs?"+query, nil)
recorder := httptest.NewRecorder()
GetLogs(&appcontext.Context{Role: role, UserID: 42}, recorder, request)
if recorder.Header().Get("Cache-Control") != "no-store" {
t.Fatal("sensitive log response can be cached")
}
var result response.Response
if err := json.Unmarshal(recorder.Body.Bytes(), &result); err != nil {
t.Fatal(err)
}
return result
}
for _, role := range []access.Role{access.RoleUser, access.RoleAdmin} {
for _, kind := range []string{"operation", "config", "mail", "runtime"} {
if got := call(role, "kind="+kind+"&actorId=42"); got.ErrorNo != response.NoAccessPrivileges {
t.Fatalf("unscoped role %s accessed %s: %d", role, kind, got.ErrorNo)
}
}
}
for _, query := range []string{"kind=unknown", "kind=mail&limit=501", "kind=mail&offset=-1", "kind=mail&from=invalid", "kind=mail&from=2026-09-08T00:00:00Z&to=2026-09-01T00:00:00Z"} {
if got := call(access.RoleSuperAdmin, query); got.ErrorNo != response.ParamsError {
t.Fatalf("invalid query accepted: %s => %d", query, got.ErrorNo)
}
}
result := call(access.RoleSuperAdmin, "kind=operation&actorId=42&limit=1")
if result.ErrorNo != 0 {
t.Fatalf("administrator query failed: %d", result.ErrorNo)
}
data := result.Data.(map[string]any)
if len(data["items"].([]any)) != 1 || data["retentionDays"] != float64(30) {
t.Fatal("log query lost records or retention policy")
}
}
+26
View File
@@ -93,3 +93,29 @@ func TestRuntimeLogCorruptionAndUnknownFilesArePreserved(t *testing.T) {
}
}
}
func TestRuntimeLogCurrentWritesDoNotWaitForArchiveRead(t *testing.T) {
w, err := New(t.TempDir())
if err != nil {
t.Fatal(err)
}
defer w.Close()
now := time.Now()
if err := w.WriteAt(now, "first"); err != nil {
t.Fatal(err)
}
w.archiveMu.Lock()
done := make(chan error, 1)
go func() { done <- w.WriteAt(now, "second") }()
select {
case err := <-done:
w.archiveMu.Unlock()
if err != nil {
t.Fatal(err)
}
case <-time.After(time.Second):
w.archiveMu.Unlock()
<-done
t.Fatal("current log write waited for archive lock")
}
}
+87
View File
@@ -0,0 +1,87 @@
import assert from 'node:assert/strict'
import test from 'node:test'
import { readFileSync } from 'node:fs'
import { compileFunction } from 'node:vm'
import { createRequire } from 'node:module'
import { computed, ref } from './vue.mjs'
const root = new URL('../../frontend/src/views/components/LogSettings/', import.meta.url)
const read = name => readFileSync(new URL(name, root), 'utf8')
const create = compileFunction(
read('LogSettings.js').replace(/^import .*$/gm, '').replace('export function', 'function') + '\nreturn useLogs()',
['computed', 'onBeforeUnmount', 'onMounted', 'ref', 'watch', 'http']
)
function fixture(get) {
let dispose
const page = create(computed, callback => { dispose = callback }, () => {}, ref, () => {}, { get })
return { page, dispose: () => dispose() }
}
test('日志页面模板和样式能编译,详情不使用原始 HTML 渲染', () => {
const require = createRequire(new URL('../../frontend/package.json', import.meta.url))
const { parse, compileScript, compileStyle } = require('@vue/compiler-sfc')
const { descriptor, errors } = parse(read('LogSettings.vue'))
assert.deepEqual(errors, [])
assert.doesNotThrow(() => compileScript(descriptor, { id: 'logs', inlineTemplate: true }))
assert.deepEqual(compileStyle({ source: read('LogSettings.css'), id: 'logs', scoped: true }).errors, [])
assert.doesNotMatch(read('LogSettings.vue'), /v-html/)
})
test('日志查询传递时间与操作者筛选,并将业务失败显示为错误', async () => {
const requests = []
const { page } = fixture(async (_, options) => {
requests.push(options.params)
return requests.length === 1
? { errorNo: 0, data: { items: [{ id: 'safe' }], hasMore: false } }
: { errorNo: 500, errorMsg: '日志暂不可用' }
})
page.actorId.value = ' 42 '
page.dateRange.value = ['2026-09-01T00:00:00Z', '2026-09-08T00:00:00Z']
await page.search()
assert.equal(requests[0].actorId, '42')
assert.equal(requests[0].from, '2026-09-01T00:00:00.000Z')
assert.equal(page.items.value.length, 1)
await page.search()
assert.equal(page.error.value, '日志暂不可用')
assert.equal(page.items.value.length, 0)
assert.equal(page.displayActor({ actorId: '0' }), '系统')
})
test('压缩日志短页正确返回上一页,文件过期后重置偏移', async () => {
let filename = 'runtime-2026-08-15.log.gz'
const offsets = []
const { page } = fixture(async (_, { params }) => {
if (!params.file) return { errorNo: 0, data: { files: [{ name: filename, compressed: true }] } }
offsets.push(params.offset)
return { errorNo: 0, data: { lines: Array(params.offset === 0 ? 8 : 12).fill('日志'), hasMore: true } }
})
page.category.value = 'runtime'
await page.search()
await page.next()
await page.next()
await page.previous()
assert.deepEqual(offsets, [0, 8, 20, 8])
filename = 'runtime-2026-08-16.log.gz'
await page.next()
assert.equal(page.offset.value, 0)
assert.equal(offsets.at(-1), 0)
})
test('慢响应及卸载后的响应不得覆盖最新日志', async () => {
let complete
let count = 0
const { page, dispose } = fixture(async () => {
if (++count === 1) return new Promise(resolve => { complete = resolve })
return { errorNo: 0, data: { items: [{ id: 'new' }] } }
})
const first = page.search()
await page.search()
complete({ errorNo: 0, data: { items: [{ id: 'old' }] } })
await first
assert.equal(page.items.value[0].id, 'new')
const last = page.search()
dispose()
await last
assert.equal(page.items.value[0].id, 'new')
})
+1 -1
View File
@@ -48,7 +48,7 @@ test('开发启动必须固定运行配置根目录并集中保存日志', async
assert.match(content, /\$workingDirectory = \$runtime/)
for (const name of ['spam_block.exe', 'pmail_telegram_push.exe', 'wechat_push.exe']) assert.ok(content.includes(name))
assert.match(content, /Join-Path \$runtime 'smail\.exe'/)
assert.match(content, /Join-Path \$runtime 'log'/)
assert.match(content, /Join-Path \$root 'test-log\\service-launch'/)
assert.match(content, /-WindowStyle Hidden/)
assert.doesNotMatch(content, /SkipBuild/)
assert.match(content, /--dev-disable-admin-reset/)
+8 -1
View File
@@ -35,7 +35,7 @@ test('二级菜单只发送可见且尚未选中的选项,不提前修改父
test('一级菜单保留能力过滤和当前分类标题联动', () => {
const source = read('HomeHeader/HomeHeader.js')
const names = [
'EpMenu', 'Lock', 'Connection', 'Setting', 'FolderOpened', 'Filter', 'User', 'Grid',
'EpMenu', 'Lock', 'Connection', 'Setting', 'FolderOpened', 'Filter', 'User', 'Grid', 'Document',
'SettingsPageStatus', 'BrandLogo'
]
const createPage = compileFunction(
@@ -64,6 +64,13 @@ test('一级菜单保留能力过滤和当前分类标题联动', () => {
assert.equal(page.settingsMenu.value.some(item => item.key === 'plugins'), false)
capabilities.add('plugin.read')
assert.equal(page.settingsMenu.value.some(item => item.key === 'plugins'), true)
capabilities.add('audit.read')
for (const role of ['user', 'admin']) {
store.role = role
assert.equal(page.settingsMenu.value.some(item => item.key === 'logs'), false)
}
store.role = 'super_admin'
assert.equal(page.settingsMenu.value.at(-1).key, 'logs')
})
test('三级菜单只发送当前分组的可见子项,选中状态仍由父页面确认', () => {
+1
View File
@@ -49,6 +49,7 @@ if ((suite === 'all' || suite === 'backend') && result === 0) {
const args = extra[0] === '--' ? extra.slice(1) : extra
// 独立回归源码集中放在 test/backend,通过 overlay 保留同包测试语义。
const replacements = {
'backend/controllers/logs_api_test.go': 'test/backend/logs_api_test.go',
'backend/services/logstore/log_store_test.go': 'test/backend/log_store_test.go',
'backend/services/runtimelog/runtime_logs_test.go': 'test/backend/runtime_logs_test.go',
'backend/db/migration/log_migration_test.go': 'test/backend/log_migration_test.go',