限制系统邮件记录仅超管可见并校验唯一超级管理员
Security Checks / security (push) Waiting to run

This commit is contained in:
xuans committed 2026-09-15 21:00:31 +08:00
1 parent 65ed505237
commit 3795c34218
17 files changed
+398 -28

No files matched your search

+30
View File
@@ -2,11 +2,41 @@ package logstore
import (
"context"
"errors"
"fmt"
"testing"
"time"
)
func TestSystemMailScopeIntersectsPermissionsAndPagination(t *testing.T) {
s := testStore(t)
now := time.Now().UTC()
for index, actor := range []string{"0", "4", "", "0"} {
if err := s.Write(context.Background(), Entry{ID: fmt.Sprint(index), Kind: "mail", ActorID: actor, CreatedAt: now.Add(-time.Duration(index) * time.Minute), Action: "投递邮件", Result: "success", Payload: []byte(`{}`)}); err != nil {
t.Fatal(err)
}
}
for page, actor := range []string{"0", "", "0"} {
items, err := s.Query(context.Background(), Query{Kind: "mail", SystemOnly: true, Limit: 1, Offset: page})
if err != nil || len(items) != 1 || items[0].ActorID != actor {
t.Fatalf("系统邮件分页错误:%+v %v", items, err)
}
}
for _, includeUsers := range []bool{false, true} {
items, err := s.Query(context.Background(), Query{Kind: "mail", SystemOnly: true, ScopeActorID: "4", IncludeOrdinaryUsers: includeUsers})
if err != nil || len(items) != 0 {
t.Fatal("系统筛选扩大了权限范围")
}
}
items, err := s.Query(context.Background(), Query{Kind: "mail", SystemOnly: true, From: now.Add(-time.Minute), To: now})
if err != nil || len(items) != 1 {
t.Fatal("系统筛选没有遵守时间窗口")
}
if _, err := s.Query(context.Background(), Query{Kind: "operation", SystemOnly: true}); !errors.Is(err, ErrInvalid) {
t.Fatal("非邮件分类接受了系统邮件筛选")
}
}
func TestLogScopeFiltersBeforePagination(t *testing.T) {
s := testStore(t)
if _, err := s.db.Exec(`INSERT INTO "user" (id, account, name, password, role, is_admin) VALUES (1,'root','Root','hash','super_admin',1),(2,'manager','Manager','hash','admin',1),(3,'other-manager','Other','hash','admin',1),(4,'alice','Alice','hash','user',0),(5,'legacy','Legacy','hash','legacy',0),(6,'legacy-manager','Legacy admin','hash','legacy',1),(7,'user-admin-flag','User admin flag','hash','user',1)`); err != nil {
+16 -1
View File
@@ -66,11 +66,14 @@ func TestLogsAPIRejectsUnscopedAccessAndValidatesQueries(t *testing.T) {
}
}
for _, role := range []access.Role{access.RoleUser, access.RoleAdmin} {
if got := call(role, "kind=mail&systemOnly=true"); got.ErrorNo != response.NoAccessPrivileges {
t.Fatalf("低权限账号能够查询系统邮件:%s", role)
}
if got := call(role, "kind=runtime&listFiles=true"); got.ErrorNo != response.NoAccessPrivileges {
t.Fatalf("低权限用户能读取全局文件列表:%s", role)
}
}
for _, query := range []string{"kind=config", "kind=unknown", "kind=mail&limit=501", "kind=mail&offset=-1", "kind=mail&from=invalid", "kind=mail&from=2026-09-08T00:00:00Z&to=2026-09-01T00:00:00Z"} {
for _, query := range []string{"kind=operation&systemOnly=true", "kind=mail&systemOnly=1", "kind=config", "kind=unknown", "kind=mail&limit=501", "kind=mail&offset=-1", "kind=mail&from=invalid", "kind=mail&from=2026-09-08T00:00:00Z&to=2026-09-01T00:00:00Z"} {
if got := call(access.RoleSuperAdmin, query); got.ErrorNo != response.ParamsError {
t.Fatalf("invalid query accepted: %s => %d", query, got.ErrorNo)
}
@@ -122,4 +125,16 @@ func TestLogsAPIRejectsUnscopedAccessAndValidatesQueries(t *testing.T) {
t.Fatalf("指定时段:%+v", history)
}
}
filtered := call(access.RoleSuperAdmin, "kind=mail&systemOnly=true")
if filtered.ErrorNo != 0 || len(filtered.Data.(map[string]any)["items"].([]any)) != 10 {
t.Fatal("超级管理员无法筛选系统邮件")
}
for _, role := range []access.Role{access.RoleAdmin, access.RoleUser} {
for _, query := range []string{"kind=mail", "kind=mail&actorId=0", "kind=mail&systemOnly=false"} {
got := call(role, query)
if got.ErrorNo != 0 || len(got.Data.(map[string]any)["items"].([]any)) != 0 {
t.Fatal("低权限账号读取到了系统邮件")
}
}
}
}
+132
View File
@@ -0,0 +1,132 @@
package setup
import (
"errors"
"path/filepath"
"sync"
"testing"
"git.pcux.cn/xuans/Smail/config"
"git.pcux.cn/xuans/Smail/db"
"git.pcux.cn/xuans/Smail/models"
appcontext "git.pcux.cn/xuans/Smail/utils/context"
)
func prepareUniqueAdminDatabase(t *testing.T) {
t.Helper()
oldConfig, oldSnapshot := config.Instance, config.CurrentConfig()
oldManager, oldDB := config.CurrentManager(), db.Instance
config.Instance = &config.Config{DbType: config.DBTypeSQLite, DbDSN: filepath.Join(t.TempDir(), "setup.db")}
config.PublishConfigSnapshot(config.Instance)
config.SetRuntimeManager(nil)
db.Instance = nil
t.Setenv("SMAIL_ENABLE_LEGACY_SYNC2", "0")
t.Cleanup(func() {
if db.Instance != nil && db.Instance != oldDB {
_ = db.Instance.Close()
}
db.Instance = oldDB
config.Instance = oldConfig
config.PublishConfigSnapshot(oldSnapshot)
config.SetRuntimeManager(oldManager)
})
if err := db.Init(""); err != nil {
t.Fatal(err)
}
}
func TestConcurrentAdministratorInitialization(t *testing.T) {
prepareUniqueAdminDatabase(t)
var group sync.WaitGroup
results := make(chan error, 4)
for _, account := range []string{"first", "second", "third", "fourth"} {
group.Add(1)
go func(account string) {
defer group.Done()
results <- SetAdminPassword(&appcontext.Context{}, account, "StrongP12")
}(account)
}
group.Wait()
close(results)
successes := 0
for err := range results {
if err == nil {
successes++
}
}
if successes != 1 {
t.Fatalf("初始化成功次数:%d", successes)
}
if err := db.ValidateSuperAdmin(db.Instance); err != nil {
t.Fatal(err)
}
}
func TestSetupRejectsMissingMigrationLock(t *testing.T) {
prepareUniqueAdminDatabase(t)
// 仅破坏本测试的临时迁移记录,不读取或清空运行数据库。
if _, err := db.Instance.Exec("DELETE FROM schema_migration WHERE version = 1"); err != nil {
t.Fatal(err)
}
if err := SetAdminPassword(&appcontext.Context{}, "root", "StrongP12"); err == nil {
t.Fatal("缺少锁记录仍创建了账号")
}
count, err := db.Instance.Count(new(models.User))
if err != nil || count != 0 {
t.Fatalf("失败初始化写入了账号:%d %v", count, err)
}
}
func TestSetupDoesNotPromoteSoleOrdinaryAccount(t *testing.T) {
prepareUniqueAdminDatabase(t)
user := models.User{Account: "ordinary", Name: "ordinary", Password: "unused", Role: "user"}
if _, err := db.Instance.Insert(&user); err != nil {
t.Fatal(err)
}
if err := db.Instance.Close(); err != nil {
t.Fatal(err)
}
db.Instance = nil
if err := db.Init(""); err != nil {
t.Fatal(err)
}
account, err := GetAdminPassword(&appcontext.Context{})
if err != nil || account != "" {
t.Fatalf("把普通用户当作超级管理员:%q %v", account, err)
}
if err := db.ValidateSuperAdmin(db.Instance); !errors.Is(err, db.ErrSuperAdminInvariant) {
t.Fatal("普通用户被自动提权")
}
if err := SetAdminPassword(&appcontext.Context{}, "root", "StrongP12"); err == nil {
t.Fatal("非空库重新初始化")
}
for _, account := range []string{"root", "duplicate"} {
if _, err := db.Instance.Insert(&models.User{Account: account, Name: account, Password: "unused", Role: "super_admin"}); err != nil {
t.Fatal(err)
}
got, err := GetAdminPassword(&appcontext.Context{})
if account == "root" && (err != nil || got != "root") {
t.Fatalf("超级管理员查询错误:%q %v", got, err)
}
if account == "duplicate" && !errors.Is(err, db.ErrSuperAdminInvariant) {
t.Fatal("重复超级管理员没有被拒绝")
}
}
}
func TestFinishRejectsDuplicateSuperAdminBeforeWritingConfiguration(t *testing.T) {
prepareFinishConfigTest(t)
if err := config.WriteConfig(&config.Config{SetupState: config.SetupStateBootstrap}); err != nil {
t.Fatal(err)
}
if _, err := db.Instance.Insert(&models.User{Account: "duplicate", Name: "test", Password: "unused", Role: "super_admin"}); err != nil {
t.Fatal(err)
}
if err := Finish(); !errors.Is(err, db.ErrSuperAdminInvariant) {
t.Fatal("初始化完成时未验证唯一超级管理员")
}
cfg, err := config.ReadConfig()
if err != nil || cfg.IsInit || cfg.SetupState != config.SetupStateBootstrap {
t.Fatal("非法账号状态仍完成了初始化")
}
}
+63
View File
@@ -0,0 +1,63 @@
package db
import (
"errors"
"path/filepath"
"reflect"
"testing"
"git.pcux.cn/xuans/Smail/models"
"xorm.io/xorm"
)
func TestSuperAdminInvariantDoesNotMutateAccounts(t *testing.T) {
if !errors.Is(ValidateSuperAdmin(nil), ErrSuperAdminInvariant) {
t.Fatal("未初始化数据库没有被拒绝")
}
for _, tc := range []struct {
name string
users []models.User
valid bool
}{
{"empty", nil, false},
{"ordinary", []models.User{{Role: "user"}}, false},
{"explicit-user", []models.User{{Role: "user", IsAdmin: 1}}, false},
{"single", []models.User{{Role: "super_admin"}}, true},
{"disabled", []models.User{{Role: "super_admin", Disabled: 1}}, false},
{"duplicate", []models.User{{Role: "super_admin"}, {Role: "super_admin", Disabled: 1}}, false},
{"legacy", []models.User{{Role: "legacy", IsAdmin: 1}}, true},
{"mixed-duplicate", []models.User{{Role: "super_admin"}, {Role: "legacy", IsAdmin: 1}}, false},
{"multiple-admins", []models.User{{Role: "super_admin"}, {Role: "admin", IsAdmin: 1}, {Role: "admin", IsAdmin: 1}, {Role: "user"}}, true},
} {
t.Run(tc.name, func(t *testing.T) {
engine, err := xorm.NewEngine("sqlite", filepath.Join(t.TempDir(), "accounts.db"))
if err != nil {
t.Fatal(err)
}
defer engine.Close()
if err := engine.Sync2(new(models.User)); err != nil {
t.Fatal(err)
}
for index, user := range tc.users {
user.Account, user.Name, user.Password = string(rune('a'+index)), "test", "unused"
if _, err := engine.Insert(&user); err != nil {
t.Fatal(err)
}
}
var before, after []models.User
if err := engine.OrderBy("id").Find(&before); err != nil {
t.Fatal(err)
}
err = ValidateSuperAdmin(engine)
if (err == nil) != tc.valid || (!tc.valid && !errors.Is(err, ErrSuperAdminInvariant)) {
t.Fatalf("唯一性检查不符合预期:%v", err)
}
if err := engine.OrderBy("id").Find(&after); err != nil {
t.Fatal(err)
}
if !reflect.DeepEqual(before, after) {
t.Fatal("检查意外修改了账号")
}
})
}
}
+23
View File
@@ -19,6 +19,29 @@ function fixture(get, role = 'super_admin') {
return { page, dispose: () => dispose() }
}
test('系统收发信筛选仅超管可用,切换时不携带冲突的操作者编号', async () => {
for (const role of ['super_admin', 'admin', 'user']) {
const requests = []
const { page } = fixture(async (_, { params }) => {
requests.push(params)
return { errorNo: 0, data: { items: [] } }
}, role)
page.category.value = 'mail'
page.actorId.value = '42'
page.mailScope.value = 'system'
await page.search()
assert.equal(page.canFilterSystemMail.value, role === 'super_admin')
assert.equal(requests[0].systemOnly, role === 'super_admin' ? true : undefined)
assert.equal(requests[0].actorId, role === 'admin' ? '42' : undefined)
page.mailScope.value = 'all'
await page.search()
assert.equal(requests[1].systemOnly, undefined)
assert.equal(requests[1].actorId, role === 'user' ? undefined : '42')
assert.equal(page.displayActor({ actorId: '0', payload: { actorName: 'xuans' } }), '系统')
}
assert.match(read('LogSettings.vue'), /v-if="canFilterSystemMail"/)
})
test('普通用户不发送操作者筛选,管理员保留范围内筛选', async () => {
for (const role of ['user', 'admin']) {
const requests = []
+3
View File
@@ -49,6 +49,9 @@ if ((suite === 'all' || suite === 'backend') && result === 0) {
const args = extra[0] === '--' ? extra.slice(1) : extra
// 独立回归源码集中放在 test/backend,通过 overlay 保留同包测试语义。
const replacements = {
'backend/db/super_admin_test.go': 'test/backend/super_admin_test.go',
'backend/services/setup/setup_findings_test.go': 'test/review/setup_findings_test.go',
'backend/services/setup/super_admin_test.go': 'test/backend/setup_super_admin_test.go',
'backend/config/plugin_role_scope_test.go': 'test/backend/plugin_role_scope_test.go',
'backend/controllers/role_scope_test.go': 'test/backend/role_scope_test.go',
'backend/services/logstore/log_scope_test.go': 'test/backend/log_scope_test.go',