fix(security): 修复gosec报告的7处代码安全分析告警(G101/G104/G203/G602)
Some checks are pending
Security Checks / security (push) Waiting to run
Some checks are pending
Security Checks / security (push) Waiting to run
This commit is contained in:
parent
e58e635492
commit
3753c4a0c9
@ -40,7 +40,8 @@ func Write(w http.ResponseWriter, authorized bool) {
|
|||||||
data := struct {
|
data := struct {
|
||||||
Authorized bool
|
Authorized bool
|
||||||
CSS template.CSS
|
CSS template.CSS
|
||||||
}{authorized, template.CSS(pageCSS)} // 仅信任编译时内嵌样式,禁止传入请求内容。
|
// #nosec G203 -- pageCSS 为编译时内嵌常量,不受用户输入控制,不存在 XSS 风险
|
||||||
|
}{authorized, template.CSS(pageCSS)}
|
||||||
if err := resultTemplate.Execute(&body, data); err != nil {
|
if err := resultTemplate.Execute(&body, data); err != nil {
|
||||||
http.Error(w, "页面暂时无法显示,请返回 Smail 查看绑定状态。", http.StatusInternalServerError)
|
http.Error(w, "页面暂时无法显示,请返回 Smail 查看绑定状态。", http.StatusInternalServerError)
|
||||||
return
|
return
|
||||||
|
|||||||
@ -365,7 +365,9 @@ func saveEmail(ctx *context.Context, size int, email *parsemail.Email, sendUserI
|
|||||||
}
|
}
|
||||||
session := db.Instance.NewSession()
|
session := db.Instance.NewSession()
|
||||||
blocked, filterErr := models.BlacklistedRecipientIDs(session, userIDs, email.SenderFilterAddresses()...)
|
blocked, filterErr := models.BlacklistedRecipientIDs(session, userIDs, email.SenderFilterAddresses()...)
|
||||||
session.Close()
|
if closeErr := session.Close(); closeErr != nil && filterErr == nil {
|
||||||
|
filterErr = closeErr
|
||||||
|
}
|
||||||
if filterErr != nil {
|
if filterErr != nil {
|
||||||
return nil, nil, filterErr
|
return nil, nil, filterErr
|
||||||
}
|
}
|
||||||
|
|||||||
@ -50,7 +50,9 @@ func GetEmailDetail(ctx *context.Context, id int, markRead bool) (*response.Emai
|
|||||||
}
|
}
|
||||||
session := db.Instance.NewSession()
|
session := db.Instance.NewSession()
|
||||||
blocked, err := models.BlacklistedRecipientIDs(session, []int{ctx.UserID}, email.FromAddress, sender.EmailAddress)
|
blocked, err := models.BlacklistedRecipientIDs(session, []int{ctx.UserID}, email.FromAddress, sender.EmailAddress)
|
||||||
session.Close()
|
if closeErr := session.Close(); closeErr != nil && err == nil {
|
||||||
|
err = closeErr
|
||||||
|
}
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|||||||
@ -171,7 +171,9 @@ func forwardToLocalUser(ctx *context.Context, email *parsemail.Email, account, f
|
|||||||
}
|
}
|
||||||
session := db.Instance.NewSession()
|
session := db.Instance.NewSession()
|
||||||
blocked, filterErr := models.BlacklistedRecipientIDs(session, []int{user.ID}, email.SenderFilterAddresses()...)
|
blocked, filterErr := models.BlacklistedRecipientIDs(session, []int{user.ID}, email.SenderFilterAddresses()...)
|
||||||
session.Close()
|
if closeErr := session.Close(); closeErr != nil && filterErr == nil {
|
||||||
|
filterErr = closeErr
|
||||||
|
}
|
||||||
if filterErr != nil {
|
if filterErr != nil {
|
||||||
return filterErr
|
return filterErr
|
||||||
}
|
}
|
||||||
|
|||||||
@ -382,7 +382,9 @@ func randomCodeFromReader(length int, reader io.Reader) (string, error) {
|
|||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
digit := int(value) % len(digits)
|
digit := int(value) % len(digits)
|
||||||
|
// #nosec G602 -- digit 取值由 int(value)%len(digits) 限定在 0-9 范围,且 counts 和 digits 长度均固定为 10,不存在切片越界
|
||||||
code[written] = digits[digit]
|
code[written] = digits[digit]
|
||||||
|
// #nosec G602 -- digit 取值限定在 0-9 范围,counts 长度为 10,不存在切片越界
|
||||||
counts[digit]++
|
counts[digit]++
|
||||||
written++
|
written++
|
||||||
if written == length {
|
if written == length {
|
||||||
|
|||||||
@ -16,6 +16,7 @@ import (
|
|||||||
|
|
||||||
const (
|
const (
|
||||||
PluginEgressSocket = "/egress.socket"
|
PluginEgressSocket = "/egress.socket"
|
||||||
|
// #nosec G101 -- 这是 HTTP 请求头名称常量,并非硬编码密码凭证
|
||||||
egressTokenHeader = "X-Smail-Egress-Token"
|
egressTokenHeader = "X-Smail-Egress-Token"
|
||||||
egressTargetHeader = "X-Smail-Egress-Target"
|
egressTargetHeader = "X-Smail-Egress-Target"
|
||||||
maxEgressRequestBytes int64 = 32 << 20
|
maxEgressRequestBytes int64 = 32 << 20
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user