修复SQLite嵌套路径迁移校验
Security Checks / security (push) Waiting to run

This commit is contained in:
xuans committed 2026-09-06 09:01:14 +08:00
1 parent 9404d7f9c8
commit 33b4258fbb
5 files changed
+45 -3

No files matched your search

@@ -172,7 +172,7 @@ func (e *SQLiteExecutor) resolveReference(reference string) (string, error) {
func validSQLiteReference(value string) bool {
value = filepath.ToSlash(strings.TrimSpace(value))
if value == "" || filepath.IsAbs(value) || isWindowsAbsoluteReference(value) || strings.ContainsAny(value, `\\:`) {
if value == "" || filepath.IsAbs(value) || isWindowsAbsoluteReference(value) || strings.HasPrefix(value, "config/") || strings.ContainsAny(value, `\\:`) {
return false
}
for _, part := range strings.Split(value, "/") {
@@ -78,6 +78,34 @@ func TestSQLiteExecutorCopiesDatabaseAndSwitchesConfiguration(t *testing.T) {
}
}
func TestSQLiteExecutorSupportsNestedReferences(t *testing.T) {
var switched config.DatabaseConfig
service, root := newSQLiteMigrationFixture(t, func(_ context.Context, candidate config.DatabaseConfig) error {
switched = candidate
return nil
})
if err := os.MkdirAll(filepath.Join(root, "config", "archive"), 0700); err != nil {
t.Fatal(err)
}
if err := os.Rename(filepath.Join(root, "config", "smail.db"), filepath.Join(root, "config", "archive", "review.db")); err != nil {
t.Fatal(err)
}
record, token, err := service.Preview(context.Background(), config.DatabaseConfig{Type: config.DatabaseTypeSQLite, LocalRef: "archive/review.db"}, 1, "archive/next.db")
if err != nil {
t.Fatal(err)
}
completed, err := service.Execute(context.Background(), record.ID, token)
if err != nil || completed.Status != StatusSucceeded {
t.Fatalf("nested migration result = %+v, error = %v", completed, err)
}
if switched.LocalRef != "archive/next.db" {
t.Fatalf("switched localRef = %q, want archive/next.db", switched.LocalRef)
}
if _, err := os.Stat(filepath.Join(root, "config", "archive", "next.db")); err != nil {
t.Fatal(err)
}
}
func TestSQLiteExecutorRejectsExistingTarget(t *testing.T) {
service, root := newSQLiteMigrationFixture(t, func(context.Context, config.DatabaseConfig) error { return nil })
if err := os.WriteFile(filepath.Join(root, "config", "smail-next.db"), []byte("existing"), 0600); err != nil {
+1 -1
View File
@@ -64,7 +64,7 @@ func buildTargetPlan(source, target config.DatabaseConfig) (Plan, error) {
return Plan{}, ErrInvalidRequest
}
if target.Type == config.DatabaseTypeSQLite {
if !sqliteTargetNamePattern.MatchString(target.LocalRef) {
if !validSQLiteReference(target.LocalRef) {
return Plan{}, ErrInvalidTargetName
}
} else if !targetNamePattern.MatchString(target.Name) {