检查点:保存项目生命周期实现与待修复回归

This commit is contained in:
xuans committed 2026-09-28 20:53:17 +08:00
1 parent fca7b796a9
commit dcca17e371
20 files changed
+1383 -27

No files matched your search

@@ -0,0 +1,111 @@
import { computed, onUnmounted, ref, watch } from "vue";
import { handleProjectSession, requestProjectAPI } from "./ProjectRequest.js";
export function useProjectLifecycle(project, canCreateProject, busy, refresh) {
const projectEditor = ref(null);
const pendingDeleteProject = ref(null);
const savingProject = ref(false);
const lifecycleError = ref("");
const lifecycleNotice = ref("");
const canEditProject = computed(() => Boolean(project.value?.can_manage_project));
const canDeleteProject = computed(() => Boolean(project.value?.can_delete_project));
let generation = 0;
let refreshing = false;
function clear() {
generation += 1;
projectEditor.value = null;
pendingDeleteProject.value = null;
savingProject.value = false;
lifecycleError.value = "";
lifecycleNotice.value = "";
}
function openProjectEditor(create = false) {
if (busy.value || savingProject.value || !(create ? canCreateProject.value : canEditProject.value)) return;
lifecycleError.value = "";
lifecycleNotice.value = "";
pendingDeleteProject.value = null;
projectEditor.value = {
create, id: create ? "" : project.value.id,
name: create ? "" : project.value.name,
description: create ? "" : project.value.description || "",
};
}
function requestDeleteProject() {
if (busy.value || savingProject.value || !canDeleteProject.value) return;
projectEditor.value = null;
lifecycleError.value = "";
lifecycleNotice.value = "";
pendingDeleteProject.value = { id: project.value.id, name: project.value.name };
}
function cancelProjectAction() {
if (savingProject.value) return;
projectEditor.value = null;
pendingDeleteProject.value = null;
lifecycleError.value = "";
}
async function mutateProject(action, id, body) {
if (busy.value || savingProject.value) return;
const current = generation;
savingProject.value = true;
lifecycleError.value = "";
lifecycleNotice.value = "";
try {
const result = await requestProjectAPI(`/api/v1/projects${action === "create" ? "" : `/${encodeURIComponent(id)}`}`, {
method: { create: "POST", update: "PUT", delete: "DELETE" }[action],
body: JSON.stringify(body),
});
if (current !== generation) return;
projectEditor.value = null;
pendingDeleteProject.value = null;
lifecycleNotice.value = action === "create"
? `项目已创建(ID:${result.id})。已返回项目首页,未显示时可翻页查看。`
: action === "delete" ? "项目已删除,已返回项目首页" : "项目资料已更新";
refreshing = true;
await refresh(action);
} catch (error) {
if (current !== generation) return;
lifecycleError.value = error.status ? handleProjectSession(error) : "请求结果未确认,请刷新项目后核对,勿重复提交";
if (error.status === 403 || error.status === 409) {
projectEditor.value = null;
pendingDeleteProject.value = null;
refreshing = true;
await refresh("conflict");
}
} finally {
refreshing = false;
if (current === generation) savingProject.value = false;
}
}
function saveProject() {
const form = projectEditor.value;
if (!form || !(form.create ? canCreateProject.value : canEditProject.value && form.id === project.value?.id)) return;
const name = form.name.trim();
const description = form.description.trim();
if (!name || [...name].length > 128 || [...description].length > 4096 || /[\u0000-\u001f\u007f]/.test(name)) {
lifecycleError.value = "请填写有效项目名称(最多 128 字),说明最多 4096 字";
return;
}
return mutateProject(form.create ? "create" : "update", form.id, { name, description });
}
function confirmDeleteProject() {
const target = pendingDeleteProject.value;
if (!target || !canDeleteProject.value || target.id !== project.value?.id) return;
return mutateProject("delete", target.id, { confirmation: target.id });
}
watch(project, () => { if (!refreshing) clear(); }, { flush: "sync" });
onUnmounted(clear);
return {
projectEditor, pendingDeleteProject, savingProject, lifecycleError, lifecycleNotice,
canEditProject, canDeleteProject, openProjectEditor, requestDeleteProject,
cancelProjectAction, saveProject, confirmDeleteProject,
};
}
@@ -0,0 +1,173 @@
import assert from "node:assert/strict";
import test from "node:test";
import { ref } from "vue";
import { mountComposable, deferred } from "../../test-support/mount.js";
import { useProjectLifecycle } from "./ProjectLifecycle.js";
import { useProjectManagement } from "./ProjectManagement.js";
const projectA = { id: "project-a", name: "项目甲", description: "说明", can_manage_project: true, can_delete_project: true, can_manage_members: false };
const projectB = { ...projectA, id: "project-b", name: "项目乙" };
async function setup(t, fetcher, refresh = async () => {}) {
const project = ref({ ...projectA });
const canCreate = ref(true);
const busy = ref(false);
const mounted = await mountComposable(t, () => useProjectLifecycle(project, canCreate, busy, refresh), fetcher);
return { ...mounted, project, canCreate, busy };
}
test("创建项目仅发送资料,编辑及删除使用固定项目标识", async (t) => {
const calls = [];
const refreshed = [];
const { state } = await setup(t, async (path, options) => {
calls.push([path, options]);
return options.method === "DELETE" ? new Response(null, { status: 204 }) : Response.json({ id: "created" });
}, async (action) => refreshed.push(action));
state.openProjectEditor(true);
state.projectEditor.value.name = " 新项目 ";
state.projectEditor.value.description = " 新说明 ";
await state.saveProject();
assert.deepEqual(JSON.parse(calls[0][1].body), { name: "新项目", description: "新说明" });
assert.equal(calls[0][0], "/api/v1/projects");
assert.equal(calls[0][1].method, "POST");
assert.match(state.lifecycleNotice.value, /created/);
state.openProjectEditor(false);
state.projectEditor.value.name = "修改项目";
await state.saveProject();
assert.equal(calls[1][0], "/api/v1/projects/project-a");
assert.equal(calls[1][1].method, "PUT");
state.requestDeleteProject();
assert.equal(calls.length, 2);
await state.confirmDeleteProject();
assert.equal(calls[2][1].method, "DELETE");
assert.deepEqual(JSON.parse(calls[2][1].body), { confirmation: "project-a" });
assert.deepEqual(refreshed, ["create", "update", "delete"]);
assert.ok(calls.every(([, options]) => options.credentials === "include" && options.cache === "no-store"));
});
test("生命周期权限和成员保存状态阻止发送变更", async (t) => {
const { state, project, canCreate, busy } = await setup(t, () => assert.fail("不应发送请求"));
canCreate.value = false;
state.openProjectEditor(true);
assert.equal(state.projectEditor.value, null);
project.value = { ...projectA, can_manage_project: false, can_delete_project: false };
state.openProjectEditor(false);
state.requestDeleteProject();
assert.equal(state.projectEditor.value, null);
assert.equal(state.pendingDeleteProject.value, null);
project.value = { ...projectA };
busy.value = true;
state.openProjectEditor(false);
assert.equal(state.projectEditor.value, null);
});
test("项目名称校验、二次确认取消和切换项目清理", async (t) => {
const { state, project } = await setup(t, () => assert.fail("不应发送请求"));
state.openProjectEditor(true);
state.projectEditor.value.name = " ";
await state.saveProject();
assert.match(state.lifecycleError.value, /项目名称/);
state.cancelProjectAction();
assert.equal(state.projectEditor.value, null);
state.requestDeleteProject();
state.cancelProjectAction();
await state.confirmDeleteProject();
state.requestDeleteProject();
project.value = { ...projectB };
assert.equal(state.pendingDeleteProject.value, null);
await state.confirmDeleteProject();
});
test("重复提交、切换及卸载后的迟到结果不修改新页面", async (t) => {
for (const change of ["switch", "unmount"]) {
await t.test(change, async (t) => {
const pending = deferred();
let calls = 0;
let refreshes = 0;
const { state, project, unmount } = await setup(t, () => { calls += 1; return pending.promise; }, async () => { refreshes += 1; });
state.requestDeleteProject();
const first = state.confirmDeleteProject();
await state.confirmDeleteProject();
assert.equal(calls, 1);
if (change === "switch") project.value = { ...projectB };
else unmount();
pending.resolve(new Response(null, { status: 204 }));
await first;
assert.equal(refreshes, 0);
assert.equal(state.lifecycleNotice.value, "");
assert.equal(state.savingProject.value, false);
});
}
});
test("拒绝及引用冲突刷新权限且不显示删除成功", async (t) => {
for (const status of [403, 409]) {
await t.test(String(status), async (t) => {
let refreshes = 0;
const { state, project } = await setup(t, async () => Response.json({ error: "存在引用或权限失效", request_id: "request-test" }, { status }), async () => {
refreshes += 1;
project.value = { ...projectA, can_manage_project: false, can_delete_project: false };
});
state.requestDeleteProject();
await state.confirmDeleteProject();
assert.equal(refreshes, 1);
assert.equal(state.lifecycleNotice.value, "");
assert.match(state.lifecycleError.value, /request-test/);
assert.equal(state.canDeleteProject.value, false);
assert.equal(state.pendingDeleteProject.value, null);
});
}
});
test("会话过期跳登录,网络中断明确结果未确认", async (t) => {
let mode = "auth";
const { state } = await setup(t, async () => {
if (mode === "network") throw new TypeError("network");
return Response.json({ error: "登录失效" }, { status: 401 });
});
const redirects = [];
window.location.assign = (path) => redirects.push(path);
state.requestDeleteProject();
await state.confirmDeleteProject();
assert.deepEqual(redirects, ["/login"]);
mode = "network";
await state.confirmDeleteProject();
assert.match(state.lifecycleError.value, /结果未确认/);
assert.equal(state.lifecycleNotice.value, "");
});
test("删除末页项目后回到首页,刷新期间不可切换或重复操作", async (t) => {
let deleted = false;
const pending = deferred();
const { state } = await mountComposable(t, useProjectManagement, async (path, options) => {
if (options.method === "DELETE") return pending.promise;
const second = new URL(path, "http://local").searchParams.get("after");
return Response.json({ items: deleted || !second ? [projectA] : [projectB], can_create_project: true, has_more: !deleted && !second, next_cursor: "project-a" });
});
await state.nextProjectPage();
assert.equal(state.selectedProject.value.id, "project-b");
state.requestDeleteProject();
const saving = state.confirmDeleteProject();
state.selectProject("project-a");
await state.previousProjectPage();
assert.equal(state.projectPage.value, 1);
deleted = true;
pending.resolve(new Response(null, { status: 204 }));
await saving;
assert.equal(state.projectPage.value, 0);
assert.equal(state.selectedProject.value.id, "project-a");
assert.match(state.lifecycleNotice.value, /已删除/);
assert.equal(state.savingProject.value, false);
});
test("新建项目未在首页出现时保留明确成功标识,不伪造目录条目", async (t) => {
const { state } = await mountComposable(t, useProjectManagement, async (_path, options) => options.method === "POST"
? Response.json({ id: "outside-first-page" }, { status: 201 })
: Response.json({ items: [projectA], can_create_project: true }));
state.openProjectEditor(true);
state.projectEditor.value.name = "末页项目";
await state.saveProject();
assert.deepEqual(state.projects.value.map((item) => item.id), ["project-a"]);
assert.match(state.lifecycleNotice.value, /outside-first-page/);
assert.match(state.lifecycleNotice.value, /翻页/);
});
@@ -45,6 +45,7 @@
.project-management button,
.project-management input,
.project-management textarea,
.project-management select {
min-height: 36px;
padding: 7px 10px;
@@ -209,6 +210,45 @@
background: #fff4df;
}
.project-actions {
display: flex;
align-items: center;
gap: 8px;
flex-wrap: wrap;
}
.project-editor {
display: grid;
grid-template-columns: minmax(160px, 1fr) minmax(240px, 2fr);
align-items: end;
gap: 12px;
margin-bottom: 18px;
padding: 16px;
border: 1px solid #dfe6f0;
border-radius: 10px;
background: #f8faff;
}
.project-editor h3,
.project-editor .project-actions {
grid-column: 1 / -1;
}
.project-editor label {
display: grid;
gap: 6px;
min-width: 0;
}
.project-editor textarea {
resize: vertical;
}
.project-management .project-danger {
color: #a12c3b;
border-color: #e2b8c0;
}
@media (max-width: 1000px) {
.project-layout {
grid-template-columns: 1fr;
@@ -227,4 +267,8 @@
.project-grant-form {
grid-template-columns: 1fr;
}
.project-editor {
grid-template-columns: 1fr;
}
}
@@ -1,6 +1,7 @@
import { onMounted, onUnmounted, ref } from "vue";
import { computed, onMounted, onUnmounted, ref } from "vue";
import { handleProjectSession, pageSizes, requestProjectAPI } from "./ProjectRequest.js";
import { useProjectMembers } from "./ProjectMembers.js";
import { useProjectLifecycle } from "./ProjectLifecycle.js";
export function useProjectManagement() {
const projects = ref([]);
@@ -12,11 +13,15 @@ export function useProjectManagement() {
const projectPage = ref(0);
const projectHasMore = ref(false);
const projectNextCursor = ref("");
const canCreateProject = ref(false);
const members = useProjectMembers(selectedProject);
const lifecycle = useProjectLifecycle(selectedProject, canCreateProject,
computed(() => loadingProjects.value || members.savingMember.value), refreshAfterMutation);
let generation = 0;
let controller;
async function loadProjects() {
async function loadProjects(options = {}) {
if (members.savingMember.value || (lifecycle.savingProject.value && options.internal !== true)) return;
const current = ++generation;
controller?.abort();
controller = new AbortController();
@@ -27,6 +32,7 @@ export function useProjectManagement() {
selectedProject.value = null;
projectHasMore.value = false;
projectNextCursor.value = "";
canCreateProject.value = false;
const query = new URLSearchParams({
page_size: String(projectPageSize.value),
after: projectCursors.value[projectPage.value],
@@ -35,6 +41,7 @@ export function useProjectManagement() {
const result = await requestProjectAPI(`/api/v1/projects?${query}`, { signal: controller.signal });
if (current !== generation) return;
projects.value = result.items || [];
canCreateProject.value = Boolean(result.can_create_project);
projectHasMore.value = Boolean(result.has_more && result.next_cursor);
projectNextCursor.value = result.next_cursor || "";
selectedProject.value = projects.value.find((item) => item.id === selectedID) || projects.value[0] || null;
@@ -45,13 +52,21 @@ export function useProjectManagement() {
}
}
async function refreshAfterMutation(action) {
if (action === "create" || action === "delete") {
projectPage.value = 0;
projectCursors.value = [""];
}
await loadProjects({ internal: true });
}
function selectProject(id) {
if (loadingProjects.value || selectedProject.value?.id === id) return;
if (loadingProjects.value || lifecycle.savingProject.value || members.savingMember.value || selectedProject.value?.id === id) return;
selectedProject.value = projects.value.find((item) => item.id === id) || null;
}
async function changeProjectPageSize(value) {
if (!pageSizes.includes(Number(value))) return;
if (lifecycle.savingProject.value || members.savingMember.value || !pageSizes.includes(Number(value))) return;
projectPageSize.value = Number(value);
projectPage.value = 0;
projectCursors.value = [""];
@@ -59,14 +74,14 @@ export function useProjectManagement() {
}
async function nextProjectPage() {
if (loadingProjects.value || !projectHasMore.value) return;
if (loadingProjects.value || lifecycle.savingProject.value || members.savingMember.value || !projectHasMore.value) return;
projectCursors.value = [...projectCursors.value.slice(0, projectPage.value + 1), projectNextCursor.value];
projectPage.value += 1;
await loadProjects();
}
async function previousProjectPage() {
if (loadingProjects.value || projectPage.value === 0) return;
if (loadingProjects.value || lifecycle.savingProject.value || members.savingMember.value || projectPage.value === 0) return;
projectPage.value -= 1;
await loadProjects();
}
@@ -78,7 +93,7 @@ export function useProjectManagement() {
});
return {
...members, projects, selectedProject, loadingProjects, projectError,
...members, ...lifecycle, canCreateProject, projects, selectedProject, loadingProjects, projectError,
projectPageSize, projectPage, projectHasMore, pageSizes,
loadProjects, selectProject, changeProjectPageSize, nextProjectPage, previousProjectPage,
};
@@ -9,6 +9,9 @@ const {
memberNotice, canManageMembers, memberPageSize, memberPage, memberHasMore,
memberForm, projectRoles, pendingRevoke, loadMembers, changeMemberPageSize,
nextMemberPage, previousMemberPage, grantMember, requestRevoke, confirmRevoke, roleLabel,
canCreateProject, projectEditor, pendingDeleteProject, savingProject,
lifecycleError, lifecycleNotice, canEditProject, canDeleteProject,
openProjectEditor, requestDeleteProject, cancelProjectAction, saveProject, confirmDeleteProject,
} = useProjectManagement();
</script>
@@ -16,10 +19,34 @@ const {
<section class="project-management" aria-label="项目与成员">
<header class="project-heading">
<h2>项目与成员</h2>
<button type="button" :disabled="loadingProjects || savingMember" @click="loadProjects">刷新项目</button>
<div class="project-actions">
<button v-if="canCreateProject" class="project-primary" type="button" :disabled="loadingProjects || savingMember || savingProject" @click="openProjectEditor(true)">创建项目</button>
<button type="button" :disabled="loadingProjects || savingMember || savingProject" @click="loadProjects">刷新项目</button>
</div>
</header>
<p v-if="projectError" class="project-error" role="alert">{{ projectError }}</p>
<div class="project-layout">
<p v-if="lifecycleError" class="project-error" role="alert">{{ lifecycleError }}</p>
<p v-if="lifecycleNotice" class="project-notice" role="status">{{ lifecycleNotice }}</p>
<form v-if="projectEditor" class="project-editor" aria-label="项目资料" @submit.prevent="saveProject">
<h3>{{ projectEditor.create ? "创建项目" : "编辑项目" }}</h3>
<label>项目名称
<input v-model="projectEditor.name" required maxlength="128" autocomplete="off" :disabled="savingProject" />
</label>
<label>项目说明
<textarea v-model="projectEditor.description" maxlength="4096" rows="2" :disabled="savingProject"></textarea>
</label>
<div class="project-actions">
<button class="project-primary" type="submit" :disabled="savingProject || loadingProjects || savingMember">{{ savingProject ? "正在保存……" : "保存项目" }}</button>
<button type="button" :disabled="savingProject" @click="cancelProjectAction">取消</button>
</div>
</form>
<div v-if="pendingDeleteProject" class="project-confirm" role="alert">
<span>确认删除项目“{{ pendingDeleteProject.name }}”({{ pendingDeleteProject.id }})?</span>
<span class="project-help" tabindex="0" title="默认项目不能删除;存在域名、服务器、绑定或成员时会拒绝删除,不会自动删除关联资源。">ⓘ</span>
<button class="project-danger" type="button" :disabled="savingProject || loadingProjects || savingMember" @click="confirmDeleteProject">{{ savingProject ? "正在删除……" : "确认删除项目" }}</button>
<button type="button" :disabled="savingProject" @click="cancelProjectAction">取消</button>
</div>
<div class="project-layout" :inert="savingProject" :aria-busy="savingProject">
<aside class="project-directory" aria-label="可见项目">
<div class="project-toolbar">
<h3>我的项目</h3>
@@ -56,7 +83,11 @@ const {
<h3 :title="selectedProject.description">{{ selectedProject.name }}</h3>
<small :title="selectedProject.id">项目 ID:{{ selectedProject.id }}</small>
</div>
<button v-if="canManageMembers" type="button" :disabled="loadingMembers || savingMember" @click="loadMembers">刷新成员</button>
<div class="project-actions">
<button v-if="canEditProject" type="button" :disabled="loadingProjects || savingMember || savingProject" @click="openProjectEditor(false)">编辑项目</button>
<button v-if="canDeleteProject" class="project-danger" type="button" :disabled="loadingProjects || savingMember || savingProject" @click="requestDeleteProject">删除项目</button>
<button v-if="canManageMembers" type="button" :disabled="loadingMembers || savingMember || savingProject" @click="loadMembers">刷新成员</button>
</div>
</div>
<p v-if="memberError" class="project-error" role="alert">{{ memberError }}</p>
<p v-if="memberNotice" class="project-notice" role="status">{{ memberNotice }}</p>