检查点:保存项目生命周期实现与待修复回归
This commit is contained in:
1 parent
fca7b796a9
commit
dcca17e371
20 files changed
+1383
-27
No files matched your search
@@ -157,6 +157,7 @@ func NewWithConfigPath(ctx context.Context, cfg config.Config, configPath string
|
||||
Config: cfg, ConfigPath: configPath, Logger: logger, Repository: repo, Servers: serverRepo, Users: userRepo, SSHKeys: sshKeys, DeploymentFactory: deployment.SSHFactory{Secrets: secretStore},
|
||||
ProjectMembers: repository.NewSQLProjectMemberRepository(db.DB, runtimeDatabaseConfig.Driver),
|
||||
ProjectDirectory: repository.NewSQLProjectMemberRepository(db.DB, runtimeDatabaseConfig.Driver),
|
||||
ProjectLifecycle: repository.NewSQLProjectMemberRepository(db.DB, runtimeDatabaseConfig.Driver),
|
||||
SetupDNS: dnsVerification, Secrets: secretStore, Firewall: firewall.NewManager(), AliyunChecker: aliyunAuthChecker,
|
||||
IssueCertificate: workflow.IssueForHTTP,
|
||||
IssueSetupCertificate: func(ctx context.Context, request certificate.SetupCertificateRequest) (certificate.SavedResource, error) {
|
||||
|
||||
@@ -0,0 +1,53 @@
|
||||
package app
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/domain"
|
||||
)
|
||||
|
||||
// 走真实应用装配和会话登录,不能以测试夹具注入证明生产接线正确。
|
||||
func TestApplicationWiresProjectLifecycleAPI(t *testing.T) {
|
||||
cfg := readyApplicationConfig(t)
|
||||
application, err := NewWithConfigPath(t.Context(), cfg, filepath.Join(cfg.Paths.Config, "scert.json"))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
t.Cleanup(func() { _ = application.Close() })
|
||||
var cookies []*http.Cookie
|
||||
request := func(method, path, body string, status int) *httptest.ResponseRecorder {
|
||||
t.Helper()
|
||||
req := httptest.NewRequest(method, path, strings.NewReader(body))
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
for _, cookie := range cookies {
|
||||
req.AddCookie(cookie)
|
||||
}
|
||||
response := httptest.NewRecorder()
|
||||
application.HTTP.Handler().ServeHTTP(response, req)
|
||||
if response.Code != status {
|
||||
t.Fatalf("实际应用请求失败:%s %s,%d,%s", method, path, response.Code, response.Body.String())
|
||||
}
|
||||
return response
|
||||
}
|
||||
login := request(http.MethodPost, "/api/v1/auth/login", `{"identifier":"admin","password":"Test1234!"}`, 200)
|
||||
cookies = login.Result().Cookies()
|
||||
created := request(http.MethodPost, "/api/v1/projects", `{"name":"实际应用项目","description":"接线验证"}`, 201)
|
||||
var item domain.Project
|
||||
if err := json.Unmarshal(created.Body.Bytes(), &item); err != nil || item.ID == "" {
|
||||
t.Fatalf("创建未返回标识:%v", err)
|
||||
}
|
||||
path := "/api/v1/projects/" + item.ID
|
||||
request(http.MethodPut, path, `{"name":"修改后的项目"}`, 200)
|
||||
directory := request(http.MethodGet, "/api/v1/projects?page_size=30", "", 200)
|
||||
if !strings.Contains(directory.Body.String(), `"can_create_project":true`) || !strings.Contains(directory.Body.String(), "修改后的项目") {
|
||||
t.Fatalf("真实目录未更新或缺少能力:%s", directory.Body.String())
|
||||
}
|
||||
request(http.MethodDelete, path, fmt.Sprintf(`{"confirmation":%q}`, item.ID), 204)
|
||||
request(http.MethodPut, path, `{"name":"已删除项目"}`, 403)
|
||||
}
|
||||
@@ -0,0 +1,135 @@
|
||||
package httpapi
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"net/http"
|
||||
"time"
|
||||
|
||||
"github.com/gin-gonic/gin"
|
||||
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/domain"
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/repository"
|
||||
)
|
||||
|
||||
func (s *Server) registerProjectLifecycleRoutes() {
|
||||
api := s.router.Group("/api/v1/projects", privateProjectResponse)
|
||||
api.POST("", s.projectFailureAudit("project.create"), s.requireAuthenticated, s.createProject)
|
||||
api.PUT("/:projectID", s.projectFailureAudit("project.update"), s.requireAuthenticated, s.updateProject)
|
||||
api.DELETE("/:projectID", s.projectFailureAudit("project.delete"), s.requireAuthenticated, s.deleteProject)
|
||||
}
|
||||
|
||||
func (s *Server) projectLifecycleReady(c *gin.Context, creating bool) bool {
|
||||
if s.projectLifecycle == nil {
|
||||
s.writeError(c, http.StatusServiceUnavailable, "项目管理服务尚未就绪", nil)
|
||||
return false
|
||||
}
|
||||
if c.Request.URL.RawQuery != "" || (!creating && !validMemberIdentifier(c.Param("projectID"))) {
|
||||
s.writeError(c, http.StatusBadRequest, "项目请求参数无效", nil)
|
||||
return false
|
||||
}
|
||||
return true
|
||||
}
|
||||
|
||||
type projectDetailsRequest struct {
|
||||
Name string `json:"name"`
|
||||
Description string `json:"description"`
|
||||
}
|
||||
|
||||
func (s *Server) projectDetails(c *gin.Context) (projectDetailsRequest, bool) {
|
||||
var input projectDetailsRequest
|
||||
if err := bindJSON(c, &input, jsonRequestBodyLimit); err != nil {
|
||||
s.writeError(c, http.StatusBadRequest, "项目资料格式无效", nil)
|
||||
return input, false
|
||||
}
|
||||
item := (domain.Project{ID: "validation", Name: input.Name, Description: input.Description}).Normalize()
|
||||
if err := item.Validate(); err != nil {
|
||||
s.writeError(c, http.StatusBadRequest, err.Error(), nil)
|
||||
return input, false
|
||||
}
|
||||
return projectDetailsRequest{Name: item.Name, Description: item.Description}, true
|
||||
}
|
||||
|
||||
func (s *Server) createProject(c *gin.Context) {
|
||||
if !s.projectLifecycleReady(c, true) {
|
||||
return
|
||||
}
|
||||
input, ok := s.projectDetails(c)
|
||||
if !ok {
|
||||
return
|
||||
}
|
||||
item, err := s.projectLifecycle.CreateManagedProject(c.Request.Context(), c.GetString(authenticatedActorKey), input.Name, input.Description)
|
||||
if err != nil {
|
||||
s.writeProjectLifecycleError(c, err)
|
||||
return
|
||||
}
|
||||
c.JSON(http.StatusCreated, item)
|
||||
}
|
||||
|
||||
func (s *Server) updateProject(c *gin.Context) {
|
||||
if !s.projectLifecycleReady(c, false) {
|
||||
return
|
||||
}
|
||||
input, ok := s.projectDetails(c)
|
||||
if !ok {
|
||||
return
|
||||
}
|
||||
if err := s.projectLifecycle.UpdateManagedProject(c.Request.Context(), c.GetString(authenticatedActorKey), c.Param("projectID"), input.Name, input.Description); err != nil {
|
||||
s.writeProjectLifecycleError(c, err)
|
||||
return
|
||||
}
|
||||
c.JSON(http.StatusOK, gin.H{"message": "项目资料已更新"})
|
||||
}
|
||||
|
||||
func (s *Server) deleteProject(c *gin.Context) {
|
||||
if !s.projectLifecycleReady(c, false) {
|
||||
return
|
||||
}
|
||||
var input struct {
|
||||
Confirmation string `json:"confirmation"`
|
||||
}
|
||||
if err := bindJSON(c, &input, jsonRequestBodyLimit); err != nil || input.Confirmation != c.Param("projectID") {
|
||||
s.writeError(c, http.StatusBadRequest, "请确认要删除的项目,确认标识必须与目标项目一致", nil)
|
||||
return
|
||||
}
|
||||
if err := s.projectLifecycle.DeleteManagedProject(c.Request.Context(), c.GetString(authenticatedActorKey), c.Param("projectID")); err != nil {
|
||||
s.writeProjectLifecycleError(c, err)
|
||||
return
|
||||
}
|
||||
c.Status(http.StatusNoContent)
|
||||
}
|
||||
|
||||
func (s *Server) writeProjectLifecycleError(c *gin.Context, err error) {
|
||||
switch {
|
||||
case errors.Is(err, repository.ErrProjectAccessDenied):
|
||||
s.writeError(c, http.StatusForbidden, "无权访问项目或执行此操作", nil)
|
||||
case errors.Is(err, repository.ErrDefaultProject):
|
||||
s.writeError(c, http.StatusConflict, "默认项目不能删除", nil)
|
||||
case errors.Is(err, repository.ErrProjectReferenced):
|
||||
s.writeError(c, http.StatusConflict, "项目仍有关联资源或成员,请先移出后重试", nil)
|
||||
default:
|
||||
s.writeError(c, http.StatusInternalServerError, "项目操作失败,请稍后重试", nil)
|
||||
}
|
||||
}
|
||||
|
||||
func (s *Server) projectFailureAudit(action string) gin.HandlerFunc {
|
||||
return func(c *gin.Context) {
|
||||
c.Next()
|
||||
if c.Writer.Status() < 400 || s.projectLifecycle == nil {
|
||||
return
|
||||
}
|
||||
projectID := c.Param("projectID")
|
||||
if !validMemberIdentifier(projectID) {
|
||||
projectID = ""
|
||||
}
|
||||
ctx, cancel := context.WithTimeout(context.WithoutCancel(c.Request.Context()), 3*time.Second)
|
||||
defer cancel()
|
||||
err := s.projectLifecycle.RecordProjectFailure(ctx, repository.ProjectFailure{
|
||||
ActorID: c.GetString(authenticatedActorKey), ProjectID: projectID, Action: action,
|
||||
StatusCode: c.Writer.Status(), RequestID: requestIDFromContext(c),
|
||||
})
|
||||
if err != nil && s.logger != nil {
|
||||
s.logger.Error("项目失败审计未保存", "request_id", requestIDFromContext(c), "status", c.Writer.Status())
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,162 @@
|
||||
package httpapi
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/domain"
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/repository"
|
||||
)
|
||||
|
||||
func TestProjectLifecycleAPIFlow(t *testing.T) {
|
||||
f := newProjectMemberAPIFixture(t)
|
||||
owner := f.cookies["primary-super-admin"]
|
||||
created := serveUserRequest(f.server, owner, http.MethodPost, "/api/v1/projects", `{"name":"新项目","description":"项目说明"}`)
|
||||
var item domain.Project
|
||||
if created.Code != http.StatusCreated || json.Unmarshal(created.Body.Bytes(), &item) != nil || item.ID == "" || item.Name != "新项目" {
|
||||
t.Fatalf("项目创建失败:%d,%s", created.Code, created.Body.String())
|
||||
}
|
||||
path := "/api/v1/projects/" + item.ID
|
||||
updated := serveUserRequest(f.server, owner, http.MethodPut, path, `{"name":"更新项目","description":"更新说明"}`)
|
||||
if updated.Code != http.StatusOK {
|
||||
t.Fatalf("项目更新失败:%d,%s", updated.Code, updated.Body.String())
|
||||
}
|
||||
stored, err := repository.NewSQLProjectRepository(f.db).GetProject(t.Context(), item.ID)
|
||||
if err != nil || stored.Name != "更新项目" || !stored.CreatedAt.Equal(item.CreatedAt) {
|
||||
t.Fatalf("项目资料或创建时间错误:%+v,%v", stored, err)
|
||||
}
|
||||
deleted := serveUserRequest(f.server, owner, http.MethodDelete, path, fmt.Sprintf(`{"confirmation":%q}`, item.ID))
|
||||
if deleted.Code != http.StatusNoContent || deleted.Body.Len() != 0 {
|
||||
t.Fatalf("项目删除失败:%d,%s", deleted.Code, deleted.Body.String())
|
||||
}
|
||||
for _, response := range []string{created.Header().Get("Cache-Control"), updated.Header().Get("Cache-Control"), deleted.Header().Get("Cache-Control")} {
|
||||
if !strings.Contains(response, "no-store") {
|
||||
t.Fatal("项目变更响应允许缓存")
|
||||
}
|
||||
}
|
||||
log := f.lastAudit(t)
|
||||
if log.Action != "project.delete" || log.Status != "success" || log.ProjectID != item.ID || log.OperatorID != "primary-super-admin" {
|
||||
t.Fatalf("删除后的审计快照错误:%+v", log)
|
||||
}
|
||||
}
|
||||
|
||||
func TestProjectLifecycleAPIAuthorization(t *testing.T) {
|
||||
f := newProjectMemberAPIFixture(t)
|
||||
for _, tc := range []struct {
|
||||
name, actor, method, project string
|
||||
status int
|
||||
}{
|
||||
{"anonymous", "", http.MethodPost, "", 401},
|
||||
{"global_admin_create", "global-admin", http.MethodPost, "", 403},
|
||||
{"project_admin_create", "manager", http.MethodPost, "", 403},
|
||||
{"global_admin_update", "global-admin", http.MethodPut, "project-a", 403},
|
||||
{"viewer_update", "viewer", http.MethodPut, "project-a", 403},
|
||||
{"cross_project", "manager", http.MethodPut, "project-b", 403},
|
||||
{"missing", "primary-super-admin", http.MethodPut, "missing", 403},
|
||||
{"manager_update", "manager", http.MethodPut, "project-a", 200},
|
||||
{"default_protected", "primary-super-admin", http.MethodDelete, "default", 409},
|
||||
{"member_reference", "primary-super-admin", http.MethodDelete, "project-a", 409},
|
||||
{"manager_reference", "manager", http.MethodDelete, "project-a", 409},
|
||||
{"cross_project_delete", "manager", http.MethodDelete, "project-b", 403},
|
||||
} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
path, body := "/api/v1/projects", `{"name":"新名称","description":"不能进入审计的说明"}`
|
||||
if tc.project != "" {
|
||||
path += "/" + tc.project
|
||||
}
|
||||
if tc.method == http.MethodDelete {
|
||||
body = fmt.Sprintf(`{"confirmation":%q}`, tc.project)
|
||||
}
|
||||
response := serveUserRequest(f.server, f.cookies[tc.actor], tc.method, path, body)
|
||||
if response.Code != tc.status {
|
||||
t.Fatalf("项目权限结果错误:%d,%s", response.Code, response.Body.String())
|
||||
}
|
||||
if !strings.Contains(response.Header().Get("Cache-Control"), "no-store") {
|
||||
t.Fatal("错误响应允许缓存")
|
||||
}
|
||||
if tc.status >= 400 {
|
||||
log := f.lastAudit(t)
|
||||
if log.OperatorID != tc.actor || log.Status != "failed" || !strings.Contains(log.Message, response.Header().Get(requestIDHeader)) || strings.Contains(log.Message, "不能进入审计") {
|
||||
t.Fatalf("失败审计身份、关联或脱敏错误:%+v", log)
|
||||
}
|
||||
if (tc.project == "missing" || tc.project == "") && (log.ScopeType != repository.ScopeUnknown || log.ProjectID != "") {
|
||||
t.Fatalf("伪造项目归属:%+v", log)
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestProjectLifecycleAPIRejectsInvalidInput(t *testing.T) {
|
||||
f := newProjectMemberAPIFixture(t)
|
||||
for _, tc := range []struct{ method, suffix, body string }{
|
||||
{http.MethodPost, "", `{"name":"名称","id":"forged"}`},
|
||||
{http.MethodPost, "", `{"name":"名称","actor_id":"forged"}`},
|
||||
{http.MethodPost, "", `{"name":"名称","created_at":"2026-01-01"}`},
|
||||
{http.MethodPost, "", `{"name":"名称"} {}`},
|
||||
{http.MethodPost, "", `null`},
|
||||
{http.MethodPost, "", `{"name":" "}`},
|
||||
{http.MethodPost, "", `{"name":"` + strings.Repeat("a", 129) + `"}`},
|
||||
{http.MethodPut, "/project-b", `{"name":"名称","owner_id":"forged"}`},
|
||||
{http.MethodPut, "/project-b?ignored=1", `{"name":"名称"}`},
|
||||
{http.MethodPut, "/project-b", strings.Repeat("x", 70*1024)},
|
||||
{http.MethodDelete, "/project-b", `{}`},
|
||||
{http.MethodDelete, "/project-b", `{"confirmation":"project-a"}`},
|
||||
{http.MethodDelete, "/project-b", `{"confirmation":"project-b","actor_id":"forged"}`},
|
||||
{http.MethodDelete, "/project-b?ignored=1", `{"confirmation":"project-b"}`},
|
||||
} {
|
||||
t.Run(fmt.Sprintf("%s-%d", tc.method, len(tc.body))+tc.suffix, func(t *testing.T) {
|
||||
response := serveUserRequest(f.server, f.cookies["primary-super-admin"], tc.method, "/api/v1/projects"+tc.suffix, tc.body)
|
||||
if response.Code != http.StatusBadRequest {
|
||||
t.Fatalf("非法输入未拒绝:%d,%s", response.Code, response.Body.String())
|
||||
}
|
||||
if log := f.lastAudit(t); log.Status != "failed" || strings.Contains(log.Message, "forged") {
|
||||
t.Fatalf("失败审计错误:%+v", log)
|
||||
}
|
||||
})
|
||||
}
|
||||
var count int
|
||||
if err := f.db.QueryRowContext(t.Context(), "SELECT COUNT(*) FROM projects").Scan(&count); err != nil || count != 3 {
|
||||
t.Fatalf("非法请求改变项目:%d,%v", count, err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestProjectLifecycleAPIAuditFailureRollsBack(t *testing.T) {
|
||||
for _, method := range []string{http.MethodPost, http.MethodPut, http.MethodDelete} {
|
||||
for _, mode := range []string{"ABORT, 'sensitive-marker'", "IGNORE"} {
|
||||
t.Run(method+mode, func(t *testing.T) {
|
||||
f := newProjectMemberAPIFixture(t)
|
||||
_, err := f.db.ExecContext(t.Context(), `CREATE TRIGGER reject_project_audit BEFORE INSERT ON audit_logs
|
||||
WHEN NEW.resource_type='project' AND NEW.status='success' BEGIN SELECT RAISE(`+mode+`); END`)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
path, body := "/api/v1/projects", `{"name":"不能保存","description":"sensitive-marker"}`
|
||||
if method != http.MethodPost {
|
||||
path += "/project-b"
|
||||
}
|
||||
if method == http.MethodDelete {
|
||||
body = `{"confirmation":"project-b"}`
|
||||
}
|
||||
response := serveUserRequest(f.server, f.cookies["primary-super-admin"], method, path, body)
|
||||
if response.Code != http.StatusInternalServerError || strings.Contains(response.Body.String(), "sensitive-marker") {
|
||||
t.Fatalf("审计失败误报或泄密:%d,%s", response.Code, response.Body.String())
|
||||
}
|
||||
var count int
|
||||
if err := f.db.QueryRowContext(t.Context(), "SELECT COUNT(*) FROM projects").Scan(&count); err != nil || count != 3 {
|
||||
t.Fatalf("项目数量未回滚:%d,%v", count, err)
|
||||
}
|
||||
var name string
|
||||
if err := f.db.QueryRowContext(t.Context(), "SELECT name FROM projects WHERE id='project-b'").Scan(&name); err != nil || name != "project-b" {
|
||||
t.Fatalf("项目内容未回滚:%s,%v", name, err)
|
||||
}
|
||||
if log := f.lastAudit(t); log.Status != "failed" || log.OperatorID != "primary-super-admin" || strings.Contains(log.Message, "sensitive-marker") {
|
||||
t.Fatalf("失败审计未保存或泄密:%+v", log)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,115 @@
|
||||
package httpapi
|
||||
|
||||
import (
|
||||
"context"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/domain"
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/repository"
|
||||
)
|
||||
|
||||
type projectLifecycleBoundaryRepository struct {
|
||||
repository.ProjectLifecycleRepository
|
||||
before func()
|
||||
audit func(context.Context)
|
||||
}
|
||||
|
||||
func (r projectLifecycleBoundaryRepository) CreateManagedProject(ctx context.Context, actor, name, description string) (domain.Project, error) {
|
||||
r.before()
|
||||
return r.ProjectLifecycleRepository.CreateManagedProject(ctx, actor, name, description)
|
||||
}
|
||||
|
||||
func (r projectLifecycleBoundaryRepository) UpdateManagedProject(ctx context.Context, actor, id, name, description string) error {
|
||||
r.before()
|
||||
return r.ProjectLifecycleRepository.UpdateManagedProject(ctx, actor, id, name, description)
|
||||
}
|
||||
|
||||
func (r projectLifecycleBoundaryRepository) DeleteManagedProject(ctx context.Context, actor, id string) error {
|
||||
r.before()
|
||||
return r.ProjectLifecycleRepository.DeleteManagedProject(ctx, actor, id)
|
||||
}
|
||||
|
||||
func (r projectLifecycleBoundaryRepository) RecordProjectFailure(ctx context.Context, failure repository.ProjectFailure) error {
|
||||
if r.audit != nil {
|
||||
r.audit(ctx)
|
||||
}
|
||||
return r.ProjectLifecycleRepository.RecordProjectFailure(ctx, failure)
|
||||
}
|
||||
|
||||
func TestProjectLifecycleAPIRechecksAfterAuthentication(t *testing.T) {
|
||||
for _, change := range []string{"disable", "demote"} {
|
||||
for _, method := range []string{http.MethodPost, http.MethodPut, http.MethodDelete} {
|
||||
t.Run(change+method, func(t *testing.T) {
|
||||
f := newProjectMemberAPIFixture(t)
|
||||
called := false
|
||||
f.server.projectLifecycle = projectLifecycleBoundaryRepository{ProjectLifecycleRepository: f.members, before: func() {
|
||||
called = true
|
||||
query := "UPDATE users SET status='disabled' WHERE id='primary-super-admin'"
|
||||
if change == "demote" {
|
||||
query = "UPDATE users SET role='admin' WHERE id='primary-super-admin'"
|
||||
}
|
||||
if _, err := f.db.ExecContext(t.Context(), query); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}}
|
||||
path, body := "/api/v1/projects", `{"name":"不能保存"}`
|
||||
if method != http.MethodPost {
|
||||
path += "/project-b"
|
||||
}
|
||||
if method == http.MethodDelete {
|
||||
body = `{"confirmation":"project-b"}`
|
||||
}
|
||||
response := serveUserRequest(f.server, f.cookies["primary-super-admin"], method, path, body)
|
||||
log := f.lastAudit(t)
|
||||
if !called || response.Code != http.StatusForbidden || log.OperatorID != "primary-super-admin" || log.Status != "failed" {
|
||||
t.Fatalf("会话后的权限变化未生效:%d,%+v", response.Code, log)
|
||||
}
|
||||
var count int
|
||||
if err := f.db.QueryRowContext(t.Context(), "SELECT COUNT(*) FROM projects").Scan(&count); err != nil || count != 3 {
|
||||
t.Fatalf("撤权后项目发生变化:%d,%v", count, err)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
t.Run("project_role_revoked", func(t *testing.T) {
|
||||
f := newProjectMemberAPIFixture(t)
|
||||
f.server.projectLifecycle = projectLifecycleBoundaryRepository{ProjectLifecycleRepository: f.members, before: func() {
|
||||
if _, err := f.db.ExecContext(t.Context(), "DELETE FROM project_members WHERE user_id='manager'"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}}
|
||||
response := serveUserRequest(f.server, f.cookies["manager"], http.MethodPut, "/api/v1/projects/project-a", `{"name":"不能保存"}`)
|
||||
if response.Code != 403 {
|
||||
t.Fatalf("项目角色撤销后仍允许修改:%d", response.Code)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
func TestProjectLifecycleAPICanceledRequestKeepsBoundedAudit(t *testing.T) {
|
||||
f := newProjectMemberAPIFixture(t)
|
||||
ctx, cancel := context.WithCancel(t.Context())
|
||||
defer cancel()
|
||||
audited := false
|
||||
f.server.projectLifecycle = projectLifecycleBoundaryRepository{
|
||||
ProjectLifecycleRepository: f.members, before: cancel,
|
||||
audit: func(ctx context.Context) {
|
||||
audited = true
|
||||
deadline, ok := ctx.Deadline()
|
||||
if ctx.Err() != nil || !ok || time.Until(deadline) > 3*time.Second {
|
||||
t.Fatal("失败审计没有独立有界上下文")
|
||||
}
|
||||
},
|
||||
}
|
||||
request := httptest.NewRequest(http.MethodPost, "/api/v1/projects", strings.NewReader(`{"name":"取消项目"}`)).WithContext(ctx)
|
||||
request.Header.Set("Content-Type", "application/json")
|
||||
request.AddCookie(f.cookies["primary-super-admin"])
|
||||
response := httptest.NewRecorder()
|
||||
f.server.Handler().ServeHTTP(response, request)
|
||||
if !audited || response.Code != 500 || f.lastAudit(t).Status != "failed" {
|
||||
t.Fatalf("取消请求后审计丢失:%d", response.Code)
|
||||
}
|
||||
}
|
||||
@@ -48,7 +48,7 @@ func newProjectMemberAPIFixture(t *testing.T) projectMemberAPIFixture {
|
||||
db: db.DB, members: repository.NewSQLProjectMemberRepository(db.DB, cfg.Database.Driver),
|
||||
audit: repository.NewSQLAuditRepository(db.DB, cfg.Database.Driver), cookies: make(map[string]*http.Cookie),
|
||||
}
|
||||
f.server = New(Dependencies{Config: cfg, Users: users, ProjectMembers: f.members, ProjectDirectory: f.members, Audit: f.audit})
|
||||
f.server = New(Dependencies{Config: cfg, Users: users, ProjectMembers: f.members, ProjectDirectory: f.members, ProjectLifecycle: f.members, Audit: f.audit})
|
||||
for _, account := range []struct{ id, role string }{
|
||||
{"primary-super-admin", repository.UserRoleSuperAdmin}, {"manager", repository.UserRoleUser},
|
||||
{"global-admin", repository.UserRoleAdmin}, {"viewer", repository.UserRoleUser}, {"target", repository.UserRoleUser},
|
||||
|
||||
@@ -50,6 +50,7 @@ type Dependencies struct {
|
||||
Users repository.UserRepository
|
||||
ProjectMembers repository.ProjectMemberRepository
|
||||
ProjectDirectory repository.ProjectDirectoryRepository
|
||||
ProjectLifecycle repository.ProjectLifecycleRepository
|
||||
SSHKeys *sshkey.Service
|
||||
DeploymentFactory deployment.ClientFactory
|
||||
SetupDNS setupDNSVerifier
|
||||
@@ -83,6 +84,7 @@ type Server struct {
|
||||
users repository.UserRepository
|
||||
projectMembers repository.ProjectMemberRepository
|
||||
projectDirectory repository.ProjectDirectoryRepository
|
||||
projectLifecycle repository.ProjectLifecycleRepository
|
||||
sshKeys *sshkey.Service
|
||||
deploymentFactory deployment.ClientFactory
|
||||
setupDNS setupDNSVerifier
|
||||
@@ -145,6 +147,7 @@ func New(deps Dependencies) *Server {
|
||||
users: deps.Users,
|
||||
projectMembers: deps.ProjectMembers,
|
||||
projectDirectory: deps.ProjectDirectory,
|
||||
projectLifecycle: deps.ProjectLifecycle,
|
||||
sshKeys: deps.SSHKeys,
|
||||
deploymentFactory: deps.DeploymentFactory,
|
||||
issueCertificate: deps.IssueCertificate,
|
||||
@@ -193,6 +196,7 @@ func (s *Server) registerRoutes() {
|
||||
userAPI.PUT("/:id", s.requireSuperAdmin, s.updateUser)
|
||||
userAPI.DELETE("/:id", s.requireSuperAdmin, s.deleteUser)
|
||||
s.registerProjectMemberRoutes()
|
||||
s.registerProjectLifecycleRoutes()
|
||||
s.router.GET("/api/v1/projects", privateProjectResponse, s.requireAuthenticated, s.listVisibleProjects)
|
||||
adminAPI.GET("/domains", s.listDomains)
|
||||
adminAPI.POST("/domains", s.dnsOperation, s.createDomain)
|
||||
|
||||
@@ -17,13 +17,16 @@ type VisibleProject struct {
|
||||
Name string `json:"name"`
|
||||
Description string `json:"description"`
|
||||
CanManageMembers bool `json:"can_manage_members"`
|
||||
CanManageProject bool `json:"can_manage_project"`
|
||||
CanDeleteProject bool `json:"can_delete_project"`
|
||||
}
|
||||
|
||||
type VisibleProjectPage struct {
|
||||
Items []VisibleProject `json:"items"`
|
||||
PageSize int `json:"page_size"`
|
||||
HasMore bool `json:"has_more"`
|
||||
NextCursor string `json:"next_cursor"`
|
||||
Items []VisibleProject `json:"items"`
|
||||
PageSize int `json:"page_size"`
|
||||
HasMore bool `json:"has_more"`
|
||||
NextCursor string `json:"next_cursor"`
|
||||
CanCreateProject bool `json:"can_create_project"`
|
||||
}
|
||||
|
||||
var _ ProjectDirectoryRepository = (*SQLProjectMemberRepository)(nil)
|
||||
@@ -38,7 +41,7 @@ func (r *SQLProjectMemberRepository) ListVisibleProjects(ctx context.Context, ac
|
||||
}
|
||||
// 授权、可见性过滤与读取共用一条 SQL;有效账户没有项目时仍返回授权门行。
|
||||
// 使用 EXISTS 避免一个账户的多个角色造成重复项目和错误分页。
|
||||
rows, err := r.db.QueryContext(ctx, Rebind(r.driver, `SELECT a.id, p.id, p.name, p.description,
|
||||
rows, err := r.db.QueryContext(ctx, Rebind(r.driver, `SELECT a.id, a.role, p.id, p.name, p.description,
|
||||
CASE WHEN a.role = 'super_admin' OR EXISTS (
|
||||
SELECT 1 FROM project_members manager WHERE manager.project_id = p.id
|
||||
AND manager.user_id = a.id AND manager.role = 'project_admin'
|
||||
@@ -57,16 +60,18 @@ func (r *SQLProjectMemberRepository) ListVisibleProjects(ctx context.Context, ac
|
||||
defer rows.Close()
|
||||
allowed := false
|
||||
for rows.Next() {
|
||||
var actor string
|
||||
var actor, globalRole string
|
||||
var id, name, description sql.NullString
|
||||
var manager int
|
||||
if err := rows.Scan(&actor, &id, &name, &description, &manager); err != nil {
|
||||
if err := rows.Scan(&actor, &globalRole, &id, &name, &description, &manager); err != nil {
|
||||
return page, fmt.Errorf("读取可见项目失败:%w", err)
|
||||
}
|
||||
allowed = true
|
||||
page.CanCreateProject = globalRole == UserRoleSuperAdmin
|
||||
if id.Valid {
|
||||
page.Items = append(page.Items, VisibleProject{
|
||||
ID: id.String, Name: name.String, Description: description.String, CanManageMembers: manager == 1,
|
||||
CanManageProject: manager == 1, CanDeleteProject: manager == 1 && id.String != "default",
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
@@ -67,6 +67,9 @@ func checkProjectDirectory(t *testing.T, cfg config.DatabaseConfig) {
|
||||
t.Fatalf("项目可见性错误:%s,%+v,%v", tc.actor, page, err)
|
||||
}
|
||||
for _, item := range page.Items {
|
||||
if page.CanCreateProject != (tc.actor == "root") || item.CanManageProject != tc.manage || item.CanDeleteProject != (tc.manage && item.ID != domain.DefaultProjectID) {
|
||||
t.Fatalf("生命周期能力错误:%s,%+v,%+v", tc.actor, page, item)
|
||||
}
|
||||
if item.CanManageMembers != tc.manage || (tc.actor != "root" && item.ID == domain.DefaultProjectID) {
|
||||
t.Fatalf("全局身份被错误映射为项目权限:%s,%+v", tc.actor, item)
|
||||
}
|
||||
@@ -113,7 +116,7 @@ func checkProjectDirectory(t *testing.T, cfg config.DatabaseConfig) {
|
||||
t.Fatal(err)
|
||||
}
|
||||
page, err := repo.ListVisibleProjects(t.Context(), "manager", "", 5)
|
||||
if err != nil || len(page.Items) == 0 || page.Items[0].CanManageMembers {
|
||||
if err != nil || len(page.Items) == 0 || page.Items[0].CanManageMembers || page.Items[0].CanManageProject || page.Items[0].CanDeleteProject || page.CanCreateProject {
|
||||
t.Fatalf("撤销管理角色未生效:%+v,%v", page, err)
|
||||
}
|
||||
if err := repo.RevokeProjectRole(t.Context(), "root", "visible-00", "manager", domain.ProjectRoleReadOnly); err != nil {
|
||||
|
||||
@@ -0,0 +1,155 @@
|
||||
package repository
|
||||
|
||||
import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"errors"
|
||||
"fmt"
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/domain"
|
||||
)
|
||||
|
||||
var ErrProjectReferenced = errors.New("项目仍有关联资源或成员,请先移出后重试")
|
||||
|
||||
// ProjectLifecycleRepository 是面向已认证业务入口的仓储,不能用基础项目仓储替代授权检查。
|
||||
type ProjectLifecycleRepository interface {
|
||||
CreateManagedProject(context.Context, string, string, string) (domain.Project, error)
|
||||
UpdateManagedProject(context.Context, string, string, string, string) error
|
||||
DeleteManagedProject(context.Context, string, string) error
|
||||
RecordProjectFailure(context.Context, ProjectFailure) error
|
||||
}
|
||||
|
||||
var _ ProjectLifecycleRepository = (*SQLProjectMemberRepository)(nil)
|
||||
|
||||
func (r *SQLProjectMemberRepository) CreateManagedProject(ctx context.Context, actorID, name, description string) (domain.Project, error) {
|
||||
item, err := domain.NewProject(name, description)
|
||||
if err != nil {
|
||||
return domain.Project{}, err
|
||||
}
|
||||
err = r.changeManagedProject(ctx, actorID, item, "project.create")
|
||||
if err != nil {
|
||||
return domain.Project{}, err
|
||||
}
|
||||
return item, nil
|
||||
}
|
||||
|
||||
func (r *SQLProjectMemberRepository) UpdateManagedProject(ctx context.Context, actorID, id, name, description string) error {
|
||||
item := (domain.Project{ID: id, Name: name, Description: description}).Normalize()
|
||||
if err := item.Validate(); err != nil {
|
||||
return err
|
||||
}
|
||||
item.UpdatedAt = time.Now().UTC()
|
||||
return r.changeManagedProject(ctx, actorID, item, "project.update")
|
||||
}
|
||||
|
||||
func (r *SQLProjectMemberRepository) DeleteManagedProject(ctx context.Context, actorID, id string) error {
|
||||
return r.changeManagedProject(ctx, actorID, domain.Project{ID: strings.TrimSpace(id)}, "project.delete")
|
||||
}
|
||||
|
||||
// 授权在实际变更语句内完成;成功审计与变更同事务,不删除成员或业务资源来迎合删除请求。
|
||||
func (r *SQLProjectMemberRepository) changeManagedProject(ctx context.Context, actorID string, item domain.Project, action string) error {
|
||||
if err := r.ensureDB(); err != nil {
|
||||
return err
|
||||
}
|
||||
actorID = strings.TrimSpace(actorID)
|
||||
if actorID == "" || item.ID == "" {
|
||||
return ErrProjectAccessDenied
|
||||
}
|
||||
tx, err := r.db.BeginTx(ctx, nil)
|
||||
if err != nil {
|
||||
return fmt.Errorf("开始项目变更事务失败:%w", err)
|
||||
}
|
||||
defer tx.Rollback()
|
||||
if r.driver == "mysql" {
|
||||
var count int
|
||||
if err := tx.QueryRowContext(ctx, `SELECT COUNT(*) FROM information_schema.tables
|
||||
WHERE table_schema=DATABASE() AND table_name IN ('projects', 'audit_logs') AND engine='InnoDB'`).Scan(&count); err != nil {
|
||||
return fmt.Errorf("检查项目审计存储失败:%w", err)
|
||||
}
|
||||
if count != 2 {
|
||||
return errors.New("项目与审计表必须使用 InnoDB,拒绝无法保证回滚的变更")
|
||||
}
|
||||
}
|
||||
if err := r.writeManagedProject(ctx, tx, actorID, item, action); err != nil {
|
||||
return err
|
||||
}
|
||||
// 不把用户输入的名称、说明或请求正文写入审计;删除后仍保留真实项目范围快照。
|
||||
result, err := tx.ExecContext(ctx, Rebind(r.driver, `INSERT INTO audit_logs
|
||||
(action, resource_type, resource_id, status, message, created_at, scope_type, project_id, task_id, operator_id)
|
||||
VALUES (?, 'project', ?, 'success', ?, ?, 'project', ?, '', ?)`),
|
||||
action, item.ID, "项目变更已完成", time.Now().UTC(), item.ID, actorID)
|
||||
if err != nil {
|
||||
return fmt.Errorf("保存项目变更审计失败:%w", err)
|
||||
}
|
||||
count, err := result.RowsAffected()
|
||||
if err != nil || count != 1 {
|
||||
return errors.New("项目变更审计未写入,已回滚本次变更")
|
||||
}
|
||||
if err := tx.Commit(); err != nil {
|
||||
return fmt.Errorf("提交项目变更失败:%w", err)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
const projectHasReferences = `(EXISTS (SELECT 1 FROM domains d WHERE d.project_id = projects.id)
|
||||
OR EXISTS (SELECT 1 FROM servers s WHERE s.project_id = projects.id)
|
||||
OR EXISTS (SELECT 1 FROM domain_servers b WHERE b.project_id = projects.id)
|
||||
OR EXISTS (SELECT 1 FROM project_members m WHERE m.project_id = projects.id))`
|
||||
|
||||
func (r *SQLProjectMemberRepository) writeManagedProject(ctx context.Context, tx *sql.Tx, actorID string, item domain.Project, action string) error {
|
||||
var query string
|
||||
var args []any
|
||||
switch action {
|
||||
case "project.create":
|
||||
query = `INSERT INTO projects (id, name, description, created_at, updated_at)
|
||||
SELECT ?, ?, ?, ?, ? FROM users a WHERE a.id = ? AND a.status = 'active' AND a.role = 'super_admin'`
|
||||
args = []any{item.ID, item.Name, item.Description, item.CreatedAt, item.UpdatedAt, actorID}
|
||||
case "project.update":
|
||||
query = `UPDATE projects SET name = ?, description = ?, updated_at = ? WHERE id = ? AND ` + projectManagerPredicate
|
||||
args = []any{item.Name, item.Description, item.UpdatedAt, item.ID, actorID, item.ID}
|
||||
case "project.delete":
|
||||
query = `DELETE FROM projects WHERE id = ? AND id <> ? AND ` + projectManagerPredicate + ` AND NOT ` + projectHasReferences
|
||||
args = []any{item.ID, domain.DefaultProjectID, actorID, item.ID}
|
||||
default:
|
||||
return errors.New("项目变更动作无效")
|
||||
}
|
||||
result, err := tx.ExecContext(ctx, Rebind(r.driver, query), args...)
|
||||
if err != nil {
|
||||
return fmt.Errorf("执行项目变更失败:%w", err)
|
||||
}
|
||||
count, err := result.RowsAffected()
|
||||
if err != nil {
|
||||
return fmt.Errorf("读取项目变更结果失败:%w", err)
|
||||
}
|
||||
if count == 1 {
|
||||
return nil
|
||||
}
|
||||
if count != 0 || action == "project.create" {
|
||||
return ErrProjectAccessDenied
|
||||
}
|
||||
var name, description string
|
||||
var referenced bool
|
||||
err = tx.QueryRowContext(ctx, Rebind(r.driver, `SELECT name, description, `+projectHasReferences+
|
||||
` FROM projects WHERE id = ? AND `+projectManagerPredicate), item.ID, actorID, item.ID).Scan(&name, &description, &referenced)
|
||||
if errors.Is(err, sql.ErrNoRows) {
|
||||
return ErrProjectAccessDenied
|
||||
}
|
||||
if err != nil {
|
||||
return fmt.Errorf("核对项目变更条件失败:%w", err)
|
||||
}
|
||||
if action == "project.delete" {
|
||||
if item.ID == domain.DefaultProjectID {
|
||||
return ErrDefaultProject
|
||||
}
|
||||
if referenced {
|
||||
return ErrProjectReferenced
|
||||
}
|
||||
}
|
||||
// MySQL 秒级时间字段与相同资料可能得到零变更行;仅在当前仍有权限且内容一致时认可幂等更新。
|
||||
if action == "project.update" && r.driver == "mysql" && name == item.Name && description == item.Description {
|
||||
return nil
|
||||
}
|
||||
return errors.New("项目变更未实际生效,请刷新后重试")
|
||||
}
|
||||
@@ -0,0 +1,43 @@
|
||||
package repository
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"time"
|
||||
)
|
||||
|
||||
type ProjectFailure struct {
|
||||
ActorID string
|
||||
ProjectID string
|
||||
Action string
|
||||
StatusCode int
|
||||
RequestID string
|
||||
}
|
||||
|
||||
// 失败记录只保留已验证身份、实际范围和安全诊断,不包含请求正文或数据库原始错误。
|
||||
func (r *SQLProjectMemberRepository) RecordProjectFailure(ctx context.Context, failure ProjectFailure) error {
|
||||
if err := r.ensureDB(); err != nil {
|
||||
return err
|
||||
}
|
||||
if failure.Action != "project.create" && failure.Action != "project.update" && failure.Action != "project.delete" {
|
||||
return errors.New("项目失败审计动作无效")
|
||||
}
|
||||
if failure.StatusCode < 400 || failure.StatusCode > 599 || len(failure.ActorID) > 128 || len(failure.ProjectID) > 128 || len(failure.RequestID) > 128 {
|
||||
return errors.New("项目失败审计参数无效")
|
||||
}
|
||||
result, err := r.db.ExecContext(ctx, Rebind(r.driver, `INSERT INTO audit_logs
|
||||
(action, resource_type, resource_id, status, message, created_at, scope_type, project_id, task_id, operator_id)
|
||||
SELECT ?, 'project', ?, 'failed', ?, ?, CASE WHEN p.id IS NULL THEN 'unknown' ELSE 'project' END,
|
||||
COALESCE(p.id, ''), '', ? FROM (SELECT 1 AS marker) audit_event LEFT JOIN projects p ON p.id = ?`),
|
||||
failure.Action, failure.ProjectID, fmt.Sprintf("请求被拒绝或执行失败:HTTP %d;请求编号:%s", failure.StatusCode, failure.RequestID),
|
||||
time.Now().UTC(), failure.ActorID, failure.ProjectID)
|
||||
if err != nil {
|
||||
return fmt.Errorf("保存项目失败审计失败:%w", err)
|
||||
}
|
||||
count, err := result.RowsAffected()
|
||||
if err != nil || count != 1 {
|
||||
return errors.New("项目失败审计未写入")
|
||||
}
|
||||
return nil
|
||||
}
|
||||
@@ -0,0 +1,300 @@
|
||||
package repository
|
||||
|
||||
import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"errors"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/config"
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/database"
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/deployment"
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/domain"
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/testsupport/mysqltest"
|
||||
)
|
||||
|
||||
func TestProjectLifecycleSQLite(t *testing.T) {
|
||||
checkProjectLifecycle(t, func(t *testing.T) config.DatabaseConfig {
|
||||
cfg := config.Default(t.TempDir()).Database
|
||||
cfg.DSN = filepath.Join(t.TempDir(), "project-lifecycle.db")
|
||||
return cfg
|
||||
})
|
||||
}
|
||||
|
||||
func TestProjectLifecycleMySQLReal(t *testing.T) {
|
||||
server := mysqltest.New(t)
|
||||
checkProjectLifecycle(t, server.Database)
|
||||
}
|
||||
|
||||
func checkProjectLifecycle(t *testing.T, makeConfig func(*testing.T) config.DatabaseConfig) {
|
||||
t.Helper()
|
||||
run := func(name string, check func(*testing.T, *sql.DB, *SQLProjectMemberRepository, string)) {
|
||||
t.Run(name, func(t *testing.T) {
|
||||
cfg := makeConfig(t)
|
||||
db, err := database.Open(t.Context(), cfg)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
t.Cleanup(func() { _ = db.Close() })
|
||||
if err := database.Migrate(t.Context(), db.DB, cfg.Driver); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
for _, user := range []struct{ id, role, status string }{
|
||||
{"root", "super_admin", "active"}, {"manager", "user", "active"},
|
||||
{"global-admin", "admin", "active"}, {"viewer", "user", "active"}, {"disabled", "super_admin", "disabled"},
|
||||
} {
|
||||
_, err := db.DB.ExecContext(t.Context(), Rebind(cfg.Driver, `INSERT INTO users
|
||||
(id, username, email, password_hash, role, status) VALUES (?, ?, ?, 'test-only-no-login', ?, ?)`),
|
||||
user.id, user.id, user.id+"@example.invalid", user.role, user.status)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
check(t, db.DB, NewSQLProjectMemberRepository(db.DB, cfg.Driver), cfg.Driver)
|
||||
})
|
||||
}
|
||||
run("create_update_delete_and_history", func(t *testing.T, db *sql.DB, repo *SQLProjectMemberRepository, driver string) {
|
||||
item, err := repo.CreateManagedProject(t.Context(), "root", " 项目一 ", "说明")
|
||||
if err != nil || item.ID == "" || item.ID == domain.DefaultProjectID || item.Name != "项目一" {
|
||||
t.Fatalf("创建失败:%+v,%v", item, err)
|
||||
}
|
||||
projects := NewSQLProjectRepository(db, driver)
|
||||
before, err := projects.GetProject(t.Context(), item.ID)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
for i := 0; i < 2; i++ {
|
||||
if err := repo.UpdateManagedProject(t.Context(), "root", item.ID, "项目二", "新说明"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
after, err := projects.GetProject(t.Context(), item.ID)
|
||||
if err != nil || !after.CreatedAt.Equal(before.CreatedAt) || after.ID != before.ID || after.Name != "项目二" {
|
||||
t.Fatalf("更新破坏身份:%+v,%v", after, err)
|
||||
}
|
||||
if err := repo.DeleteManagedProject(t.Context(), "root", item.ID); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := projects.GetProject(t.Context(), item.ID); !errors.Is(err, sql.ErrNoRows) {
|
||||
t.Fatalf("项目未删除:%v", err)
|
||||
}
|
||||
var count int
|
||||
if err := db.QueryRowContext(t.Context(), Rebind(driver, `SELECT COUNT(*) FROM audit_logs WHERE resource_type='project'
|
||||
AND resource_id=? AND project_id=? AND scope_type='project' AND operator_id='root' AND status='success'`), item.ID, item.ID).Scan(&count); err != nil || count != 4 {
|
||||
t.Fatalf("删除后丢失真实审计:%d,%v", count, err)
|
||||
}
|
||||
})
|
||||
for _, actor := range []string{"", "missing", "manager", "global-admin", "viewer", "disabled"} {
|
||||
run("create_denied_"+actor, func(t *testing.T, db *sql.DB, repo *SQLProjectMemberRepository, driver string) {
|
||||
if _, err := repo.CreateManagedProject(t.Context(), actor, "无权创建", "不应保存"); !errors.Is(err, ErrProjectAccessDenied) {
|
||||
t.Fatalf("错误授权:%v", err)
|
||||
}
|
||||
var count int
|
||||
if err := db.QueryRowContext(t.Context(), `SELECT COUNT(*) FROM projects`).Scan(&count); err != nil || count != 1 {
|
||||
t.Fatalf("拒绝后产生项目:%d,%v", count, err)
|
||||
}
|
||||
})
|
||||
}
|
||||
run("project_manager_and_revocation", func(t *testing.T, db *sql.DB, repo *SQLProjectMemberRepository, driver string) {
|
||||
item, err := repo.CreateManagedProject(t.Context(), "root", "权限测试", "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := repo.GrantProjectRole(t.Context(), "root", item.ID, "manager", domain.ProjectRoleAdmin); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := repo.UpdateManagedProject(t.Context(), "manager", item.ID, "合法修改", ""); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
for _, actor := range []string{"viewer", "global-admin", "disabled"} {
|
||||
if err := repo.UpdateManagedProject(t.Context(), actor, item.ID, "越权修改", ""); !errors.Is(err, ErrProjectAccessDenied) {
|
||||
t.Fatalf("错误更新授权:%s,%v", actor, err)
|
||||
}
|
||||
if err := repo.DeleteManagedProject(t.Context(), actor, item.ID); !errors.Is(err, ErrProjectAccessDenied) {
|
||||
t.Fatalf("错误删除授权:%s,%v", actor, err)
|
||||
}
|
||||
}
|
||||
if err := repo.DeleteManagedProject(t.Context(), "manager", item.ID); !errors.Is(err, ErrProjectReferenced) {
|
||||
t.Fatalf("不能自动清理成员:%v", err)
|
||||
}
|
||||
if err := repo.RevokeProjectRole(t.Context(), "root", item.ID, "manager", domain.ProjectRoleAdmin); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := repo.UpdateManagedProject(t.Context(), "manager", item.ID, "撤权后修改", ""); !errors.Is(err, ErrProjectAccessDenied) {
|
||||
t.Fatalf("撤权未生效:%v", err)
|
||||
}
|
||||
if err := repo.DeleteManagedProject(t.Context(), "manager", item.ID); !errors.Is(err, ErrProjectAccessDenied) {
|
||||
t.Fatalf("撤权后仍可删除:%v", err)
|
||||
}
|
||||
if err := repo.DeleteManagedProject(t.Context(), "root", item.ID); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
})
|
||||
for _, kind := range []string{"domain", "server", "member"} {
|
||||
run("reference_"+kind, func(t *testing.T, db *sql.DB, repo *SQLProjectMemberRepository, driver string) {
|
||||
item, err := repo.CreateManagedProject(t.Context(), "root", "引用保护", "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
switch kind {
|
||||
case "domain":
|
||||
resource, err := domain.NewDomain("lifecycle.example.test", domain.CertificateSingle, nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
resource.ProjectID = item.ID
|
||||
if err := NewSQLDomainRepository(db, driver).Create(t.Context(), resource); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
case "server":
|
||||
resource := deployment.Server{ID: "server-a", Name: "项目服务器", Address: "192.0.2.10", Port: 22, Username: "deploy",
|
||||
PrivateKeyRef: "secret://ssh/test", HostKeyFingerprint: "SHA256:test", CertificatePath: "/test/cert.pem",
|
||||
PrivateKeyPath: "/test/key.pem", CertificateChainPath: "/test/chain.pem", WebServer: deployment.WebServerNginx}
|
||||
resource.ProjectID = item.ID
|
||||
if err := NewSQLServerRepository(db, driver).CreateServer(t.Context(), resource); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
case "member":
|
||||
if err := repo.GrantProjectRole(t.Context(), "root", item.ID, "viewer", domain.ProjectRoleReadOnly); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
if err := repo.DeleteManagedProject(t.Context(), "root", item.ID); !errors.Is(err, ErrProjectReferenced) {
|
||||
t.Fatalf("引用保护失败:%v", err)
|
||||
}
|
||||
if _, err := NewSQLProjectRepository(db, driver).GetProject(t.Context(), item.ID); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
})
|
||||
}
|
||||
run("default_missing_and_cancelled", func(t *testing.T, db *sql.DB, repo *SQLProjectMemberRepository, driver string) {
|
||||
if err := repo.DeleteManagedProject(t.Context(), "root", domain.DefaultProjectID); !errors.Is(err, ErrDefaultProject) {
|
||||
t.Fatalf("默认项目删除:%v", err)
|
||||
}
|
||||
if err := repo.DeleteManagedProject(t.Context(), "viewer", domain.DefaultProjectID); !errors.Is(err, ErrProjectAccessDenied) {
|
||||
t.Fatalf("默认项目泄露权限:%v", err)
|
||||
}
|
||||
if err := repo.DeleteManagedProject(t.Context(), "root", "missing"); !errors.Is(err, ErrProjectAccessDenied) {
|
||||
t.Fatalf("不存在项目:%v", err)
|
||||
}
|
||||
ctx, cancel := context.WithCancel(t.Context())
|
||||
cancel()
|
||||
if _, err := repo.CreateManagedProject(ctx, "root", "取消", ""); err == nil {
|
||||
t.Fatal("取消后创建成功")
|
||||
}
|
||||
})
|
||||
for _, action := range []string{"create", "update", "delete"} {
|
||||
run("audit_rollback_"+action, func(t *testing.T, db *sql.DB, repo *SQLProjectMemberRepository, driver string) {
|
||||
item, err := repo.CreateManagedProject(t.Context(), "root", "必须保留", "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
trigger := `CREATE TRIGGER fail_project_audit BEFORE INSERT ON audit_logs BEGIN SELECT RAISE(ABORT, 'audit-failure'); END`
|
||||
if driver == "mysql" {
|
||||
trigger = `CREATE TRIGGER fail_project_audit BEFORE INSERT ON audit_logs FOR EACH ROW SIGNAL SQLSTATE '45000' SET MESSAGE_TEXT='audit-failure'`
|
||||
}
|
||||
if _, err := db.ExecContext(t.Context(), trigger); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
switch action {
|
||||
case "create":
|
||||
_, err = repo.CreateManagedProject(t.Context(), "root", "不能保存", "")
|
||||
case "update":
|
||||
err = repo.UpdateManagedProject(t.Context(), "root", item.ID, "不能保存", "")
|
||||
case "delete":
|
||||
err = repo.DeleteManagedProject(t.Context(), "root", item.ID)
|
||||
}
|
||||
if err == nil {
|
||||
t.Fatal("审计异常仍返回成功")
|
||||
}
|
||||
loaded, err := NewSQLProjectRepository(db, driver).GetProject(t.Context(), item.ID)
|
||||
if err != nil || loaded.Name != "必须保留" {
|
||||
t.Fatalf("项目未回滚:%+v,%v", loaded, err)
|
||||
}
|
||||
var count int
|
||||
if err := db.QueryRowContext(t.Context(), "SELECT COUNT(*) FROM projects").Scan(&count); err != nil || count != 2 {
|
||||
t.Fatalf("产生部分写入:%d,%v", count, err)
|
||||
}
|
||||
})
|
||||
}
|
||||
run("nontransactional_audit_is_rejected", func(t *testing.T, db *sql.DB, repo *SQLProjectMemberRepository, driver string) {
|
||||
if driver != "mysql" {
|
||||
t.Skip("非事务引擎边界仅适用于 MySQL")
|
||||
}
|
||||
if _, err := db.ExecContext(t.Context(), "ALTER TABLE audit_logs ENGINE=MyISAM"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := repo.CreateManagedProject(t.Context(), "root", "不能保存", ""); err == nil {
|
||||
t.Fatal("非事务审计表仍被允许")
|
||||
}
|
||||
var count int
|
||||
if err := db.QueryRowContext(t.Context(), "SELECT COUNT(*) FROM projects").Scan(&count); err != nil || count != 1 {
|
||||
t.Fatalf("非事务场景产生变更:%d,%v", count, err)
|
||||
}
|
||||
})
|
||||
run("duplicate_names_and_validation", func(t *testing.T, db *sql.DB, repo *SQLProjectMemberRepository, driver string) {
|
||||
a, err := repo.CreateManagedProject(t.Context(), "root", "同名", "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
b, err := repo.CreateManagedProject(t.Context(), "root", "同名", "")
|
||||
if err != nil || a.ID == b.ID {
|
||||
t.Fatalf("重名项目没有独立标识:%v", err)
|
||||
}
|
||||
for _, name := range []string{"", strings.Repeat("中", 129), "控制\x00字符"} {
|
||||
if _, err := repo.CreateManagedProject(t.Context(), "root", name, ""); err == nil {
|
||||
t.Fatal("无效名称创建成功")
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
func TestProjectLifecycleSQLiteAuditRollback(t *testing.T) {
|
||||
for _, action := range []string{"create", "update", "delete"} {
|
||||
for _, mode := range []string{"ABORT, 'audit-failure'", "IGNORE"} {
|
||||
t.Run(action+mode, func(t *testing.T) {
|
||||
cfg := config.Default(t.TempDir()).Database
|
||||
db, err := database.Open(t.Context(), cfg)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
t.Cleanup(func() { _ = db.Close() })
|
||||
if err := database.Migrate(t.Context(), db.DB, cfg.Driver); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := db.DB.Exec(`INSERT INTO users (id, username, email, password_hash, role, status) VALUES ('root', 'root', '', 'test-only', 'super_admin', 'active')`); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
repo := NewSQLProjectMemberRepository(db.DB, cfg.Driver)
|
||||
item, err := repo.CreateManagedProject(t.Context(), "root", "保留原名", "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := db.DB.Exec(`CREATE TRIGGER reject_project_audit BEFORE INSERT ON audit_logs BEGIN SELECT RAISE(` + mode + `); END`); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
switch action {
|
||||
case "create":
|
||||
_, err = repo.CreateManagedProject(t.Context(), "root", "不能保存", "")
|
||||
case "update":
|
||||
err = repo.UpdateManagedProject(t.Context(), "root", item.ID, "不能保存", "")
|
||||
case "delete":
|
||||
err = repo.DeleteManagedProject(t.Context(), "root", item.ID)
|
||||
}
|
||||
if err == nil {
|
||||
t.Fatal("审计故障后仍然成功")
|
||||
}
|
||||
items, err := NewSQLProjectRepository(db.DB, cfg.Driver).ListProjects(t.Context())
|
||||
if err != nil || len(items) != 2 {
|
||||
t.Fatalf("事务没有回滚:%+v,%v", items, err)
|
||||
}
|
||||
loaded, err := NewSQLProjectRepository(db.DB, cfg.Driver).GetProject(t.Context(), item.ID)
|
||||
if err != nil || loaded.Name != "保留原名" {
|
||||
t.Fatalf("资料或删除未回滚:%+v,%v", loaded, err)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user