接入域名 DNS 绑定接口并修复历史 MySQL 排序规则兼容

This commit is contained in:
xuans committed 2026-10-04 05:53:36 +08:00
1 parent 45798c5ecf
commit c80530f60e
12 files changed
+370 -8

No files matched your search

@@ -0,0 +1,83 @@
package httpapi
import (
"errors"
"net/http"
"github.com/gin-gonic/gin"
"git.pcux.cn/xuans/Scert/backend/internal/domain"
"git.pcux.cn/xuans/Scert/backend/internal/repository"
)
func (s *Server) domainDNSRepository(c *gin.Context) (repository.DomainDNSAccountRepository, bool) {
repo, ok := s.projectMembers.(repository.DomainDNSAccountRepository)
if !ok {
s.writeError(c, http.StatusServiceUnavailable, "域名 DNS 账户绑定服务尚未就绪", nil)
return nil, false
}
if !domain.ValidProjectID(c.Param("id")) || c.Request.URL.RawQuery != "" {
s.writeError(c, http.StatusBadRequest, "域名 DNS 账户绑定参数无效", nil)
return nil, false
}
return repo, true
}
func (s *Server) writeDomainDNSAccountError(c *gin.Context, err error) {
switch {
case errors.Is(err, repository.ErrProjectAccessDenied):
s.writeError(c, http.StatusForbidden, "无权操作此域名的 DNS 账户绑定", nil)
case errors.Is(err, repository.ErrDNSBindingConflict), errors.Is(err, repository.ErrDNSAccountConflict):
s.writeError(c, http.StatusConflict, "域名绑定或 DNS 账户已变更,请刷新后重试", nil)
case errors.Is(err, repository.ErrDNSBindingBusy):
s.writeError(c, http.StatusConflict, "域名存在未结束的任务,暂不能变更 DNS 账户", nil)
case errors.Is(err, repository.ErrDNSBindingInvalid):
s.writeError(c, http.StatusUnprocessableEntity, "域名验证方式或 DNS 账户状态不允许绑定", nil)
default:
// 驱动错误可能含内部标识;只返回固定提示,不记录原始错误。
s.writeError(c, http.StatusServiceUnavailable, "保存或读取 DNS 账户绑定失败,请刷新后核对", nil)
}
}
func (s *Server) getDomainDNSAccount(c *gin.Context) {
repo, ok := s.domainDNSRepository(c)
if !ok {
return
}
item, err := repo.GetDomainDNSAccountBinding(c.Request.Context(), c.GetString(authenticatedActorKey), c.Param("id"))
if err != nil {
s.writeDomainDNSAccountError(c, err)
return
}
c.JSON(http.StatusOK, item)
}
func (s *Server) setDomainDNSAccount(c *gin.Context) {
repo, ok := s.domainDNSRepository(c)
if !ok {
return
}
var input struct {
AccountID *string `json:"dns_account_id"`
ExpectedBindingID *string `json:"expected_binding_id"`
AccountRevision *int64 `json:"account_revision"`
}
// 三个字段必须显式提供,禁止遗漏字段或 null 被解释成解除已有绑定。
if bindJSON(c, &input, jsonRequestBodyLimit) != nil || input.AccountID == nil || input.ExpectedBindingID == nil || input.AccountRevision == nil {
s.writeError(c, http.StatusBadRequest, "请明确提供 DNS 账户、当前绑定标识和账户版本", nil)
return
}
accountID, expectedID, revision := *input.AccountID, *input.ExpectedBindingID, *input.AccountRevision
if (expectedID != "" && !domain.ValidProjectID(expectedID)) ||
(accountID == "" && revision != 0) ||
(accountID != "" && (!domain.ValidProjectID(accountID) || revision < 1 || revision > 2147483647)) {
s.writeError(c, http.StatusBadRequest, "DNS 账户绑定标识或版本无效", nil)
return
}
item, err := repo.SetDomainDNSAccountBinding(c.Request.Context(), c.GetString(authenticatedActorKey), c.Param("id"), accountID, expectedID, revision)
if err != nil {
s.writeDomainDNSAccountError(c, err)
return
}
c.JSON(http.StatusOK, item)
}
@@ -0,0 +1,188 @@
package httpapi
import (
"encoding/json"
"fmt"
"net/http"
"net/http/httptest"
"strings"
"testing"
"git.pcux.cn/xuans/Scert/backend/internal/domain"
)
func newDomainDNSAPIFixture(t *testing.T) (projectMemberAPIFixture, domain.DNSAccount) {
t.Helper()
f, _ := newProjectResourceAPIFixture(t)
item, err := f.members.CreateDNSAccount(t.Context(), "manager", domain.DNSAccount{
ID: "account-a", ProjectID: "project-a", Name: "项目账户", Provider: "cloudflare", CredentialRef: "secret://dns/fixture-sensitive-token",
})
if err != nil {
t.Fatal(err)
}
item, err = f.members.RecordDNSAccountVerification(t.Context(), "manager", item.ID, item.Revision, true)
if err != nil {
t.Fatal(err)
}
return f, item
}
func domainDNSBody(accountID, expectedID string, revision int64) string {
return fmt.Sprintf(`{"dns_account_id":%q,"expected_binding_id":%q,"account_revision":%d}`, accountID, expectedID, revision)
}
func domainDNSRequest(t *testing.T, f projectMemberAPIFixture, actor, method, path, body string, status int) domain.DNSAccountBinding {
t.Helper()
response := serveUserRequest(f.server, f.cookies[actor], method, "/api/v1/domains/"+path+"/dns-account", body)
if response.Code != status {
t.Fatalf("域名 DNS 绑定响应错误:%s %s %s,实际 %d,期望 %d,%s", actor, method, path, response.Code, status, response.Body.String())
}
if response.Header().Get("Cache-Control") != "private, no-store" || response.Header().Get("Vary") != "Cookie" {
t.Fatal("绑定响应缺少身份缓存隔离")
}
for _, secret := range []string{"secret://", "credential_ref", "fixture-sensitive-token", "internal-sensitive-error"} {
if strings.Contains(response.Body.String(), secret) {
t.Fatal("绑定响应泄露秘密或内部错误")
}
}
var binding domain.DNSAccountBinding
if status == http.StatusOK {
if err := json.Unmarshal(response.Body.Bytes(), &binding); err != nil {
t.Fatal(err)
}
}
return binding
}
func TestDomainDNSAccountAPILifecycle(t *testing.T) {
f, account := newDomainDNSAPIFixture(t)
read := domainDNSRequest(t, f, "viewer", http.MethodGet, "domain-a", "", http.StatusOK)
if read.ID != "" || read.DomainID != "domain-a" || read.ProjectID != "project-a" {
t.Fatal("未绑定时未返回域名归属")
}
body := domainDNSBody(account.ID, "", account.Revision)
bound := domainDNSRequest(t, f, "manager", http.MethodPut, "domain-a", body, http.StatusOK)
if bound.ID == "" || bound.DNSAccountID != account.ID || bound.UpdatedAt.IsZero() {
t.Fatal("绑定未返回版本令牌")
}
read = domainDNSRequest(t, f, "viewer", http.MethodGet, "domain-a", "", http.StatusOK)
if read.ID != bound.ID || read.DNSAccountID != account.ID {
t.Fatal("读取与实际绑定不符")
}
for _, stale := range []string{body, domainDNSBody(account.ID, bound.ID, 1), domainDNSBody("", "", 0)} {
domainDNSRequest(t, f, "manager", http.MethodPut, "domain-a", stale, http.StatusConflict)
}
cleared := domainDNSRequest(t, f, "manager", http.MethodPut, "domain-a", domainDNSBody("", bound.ID, 0), http.StatusOK)
if cleared.ID != "" || cleared.DNSAccountID != "" {
t.Fatal("解除后仍返回绑定")
}
rebound := domainDNSRequest(t, f, "manager", http.MethodPut, "domain-a", body, http.StatusOK)
if rebound.ID == bound.ID {
t.Fatal("重绑重复使用旧令牌")
}
domainDNSRequest(t, f, "manager", http.MethodPut, "domain-a", domainDNSBody("", bound.ID, 0), http.StatusConflict)
var count int
if err := f.db.QueryRow(`SELECT COUNT(*) FROM audit_logs WHERE action='domain.dns_account' AND status='success' AND operator_id='manager'`).Scan(&count); err != nil || count != 3 {
t.Fatal("绑定成功审计数不符", count, err)
}
}
func TestDomainDNSAccountAPIAuthorization(t *testing.T) {
f, account := newDomainDNSAPIFixture(t)
body := domainDNSBody(account.ID, "", account.Revision)
for _, actor := range []string{"anonymous", "viewer", "global-admin", "target"} {
status := http.StatusForbidden
if actor == "anonymous" {
status = http.StatusUnauthorized
}
domainDNSRequest(t, f, actor, http.MethodPut, "domain-a", body, status)
if actor != "viewer" {
domainDNSRequest(t, f, actor, http.MethodGet, "domain-a", "", status)
}
}
for _, id := range []string{"domain-b", "missing-domain"} {
domainDNSRequest(t, f, "manager", http.MethodGet, id, "", http.StatusForbidden)
domainDNSRequest(t, f, "manager", http.MethodPut, id, body, http.StatusForbidden)
}
// 超级管理员也不能将同一账户绑定到另一个项目。
domainDNSRequest(t, f, "primary-super-admin", http.MethodPut, "domain-b", body, http.StatusForbidden)
if err := f.members.RevokeProjectRole(t.Context(), "primary-super-admin", "project-a", "manager", domain.ProjectRoleAdmin); err != nil {
t.Fatal(err)
}
domainDNSRequest(t, f, "manager", http.MethodGet, "domain-a", "", http.StatusForbidden)
domainDNSRequest(t, f, "manager", http.MethodPut, "domain-a", body, http.StatusForbidden)
}
func TestDomainDNSAccountAPIInputAndOrigin(t *testing.T) {
f, account := newDomainDNSAPIFixture(t)
for _, body := range []string{
`{}`, `null`, `{"dns_account_id":null,"expected_binding_id":"","account_revision":0}`,
`{"dns_account_id":"","expected_binding_id":null,"account_revision":0}`,
`{"dns_account_id":"","expected_binding_id":"","account_revision":null}`,
domainDNSBody("", "", 1), domainDNSBody(account.ID, "", 0), domainDNSBody(account.ID, "", 2147483648),
domainDNSBody(account.ID, "invalid/id", account.Revision),
`{"dns_account_id":"","expected_binding_id":"","account_revision":0,"actor_id":"primary-super-admin"}`,
`{"dns_account_id":"","expected_binding_id":"","account_revision":0} {}`,
} {
domainDNSRequest(t, f, "manager", http.MethodPut, "domain-a", body, http.StatusBadRequest)
}
for _, method := range []string{http.MethodGet, http.MethodPut} {
response := serveUserRequest(f.server, f.cookies["manager"], method, "/api/v1/domains/domain-a/dns-account?project_id=project-b", domainDNSBody(account.ID, "", account.Revision))
if response.Code != http.StatusBadRequest {
t.Fatal("查询参数未拒绝", response.Code)
}
}
request := httptest.NewRequest(http.MethodPut, "/api/v1/domains/domain-a/dns-account", strings.NewReader(domainDNSBody(account.ID, "", account.Revision)))
request.AddCookie(f.cookies["manager"])
request.Header.Set("Origin", "https://untrusted.example.test")
response := httptest.NewRecorder()
f.server.Handler().ServeHTTP(response, request)
if response.Code != http.StatusForbidden {
t.Fatal("跨源写入未拒绝", response.Code)
}
binding := domainDNSRequest(t, f, "manager", http.MethodGet, "domain-a", "", http.StatusOK)
if binding.ID != "" {
t.Fatal("非法请求改变绑定")
}
}
func TestDomainDNSAccountAPIDependencyAndState(t *testing.T) {
for _, failure := range []string{"unverified", "disabled", "http_challenge", "active_task", "audit", "repository"} {
t.Run(failure, func(t *testing.T) {
f, account := newDomainDNSAPIFixture(t)
status := http.StatusUnprocessableEntity
switch failure {
case "unverified":
if _, err := f.db.Exec(`UPDATE dns_accounts SET verification_state='unverified'`); err != nil {
t.Fatal(err)
}
case "disabled":
if _, err := f.db.Exec(`UPDATE dns_accounts SET status='disabled'`); err != nil {
t.Fatal(err)
}
case "http_challenge":
if _, err := f.db.Exec(`UPDATE domains SET challenge_type='http-01' WHERE id='domain-a'`); err != nil {
t.Fatal(err)
}
case "active_task":
if _, err := f.db.Exec(`INSERT INTO tasks (id,domain_id,task_type,status,message) VALUES ('active-task','domain-a','certificate_issue','running','')`); err != nil {
t.Fatal(err)
}
status = http.StatusConflict
case "audit":
if _, err := f.db.Exec(`CREATE TRIGGER reject_binding_audit BEFORE INSERT ON audit_logs WHEN NEW.action='domain.dns_account' BEGIN SELECT RAISE(ABORT,'internal-sensitive-error'); END`); err != nil {
t.Fatal(err)
}
status = http.StatusServiceUnavailable
case "repository":
f.server.projectMembers = nil
status = http.StatusServiceUnavailable
}
domainDNSRequest(t, f, "manager", http.MethodPut, "domain-a", domainDNSBody(account.ID, "", account.Revision), status)
binding, err := f.members.GetDomainDNSAccountBinding(t.Context(), "manager", "domain-a")
if err != nil || binding.ID != "" {
t.Fatal("失败请求改变绑定", err)
}
})
}
}
@@ -13,6 +13,8 @@ import (
func (s *Server) registerProjectResourceRoutes() {
api := s.router.Group("/api/v1", privateProjectResponse, s.requireAuthenticated)
api.GET("/domains", s.listDomains)
api.GET("/domains/:id/dns-account", s.getDomainDNSAccount)
api.PUT("/domains/:id/dns-account", s.requireSameOrigin, s.setDomainDNSAccount)
api.GET("/dns/accounts", s.listDNSAccounts)
api.GET("/dns/accounts/:id", s.getManagedDNSAccount)
api.POST("/dns/accounts", s.requireSameOrigin, s.createManagedDNSAccount)