补齐任务幂等并发保护
新增三数据库任务幂等登记迁移,在任务创建事务中防止重复幂等键,并补充并发回归测试与进度清单。
This commit is contained in:
1 parent
163b3e9c5d
commit
7e14bbf42f
11 files changed
+168
-5
No files matched your search
@@ -127,6 +127,17 @@ func (r *SQLTaskRepository) CreateTask(ctx context.Context, item Task) error {
|
||||
if err := validateTaskInsertResult(result); err != nil {
|
||||
return err
|
||||
}
|
||||
if item.IdempotencyKey != "" {
|
||||
idempotencyResult, idempotencyErr := tx.ExecContext(ctx, r.query(`INSERT INTO task_idempotency
|
||||
(domain_id, idempotency_key, task_id, created_at) VALUES (?, ?, ?, ?)`),
|
||||
item.DomainID, item.IdempotencyKey, item.ID, now)
|
||||
if idempotencyErr != nil {
|
||||
return fmt.Errorf("创建任务幂等记录失败:%w", idempotencyErr)
|
||||
}
|
||||
if err := validateTaskInsertResult(idempotencyResult); err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
if err := tx.Commit(); err != nil {
|
||||
return fmt.Errorf("提交任务创建事务失败:%w", err)
|
||||
}
|
||||
|
||||
@@ -209,3 +209,47 @@ func TestSQLTaskRepositoryRecoversInterruptedTasksAndAttempts(t *testing.T) {
|
||||
t.Fatalf("\u5df2\u5b8c\u6210\u4efb\u52a1\u5c1d\u8bd5\u4e0d\u5e94\u88ab\u6062\u590d\u903b\u8f91\u4fee\u6539\uff1a%+v %v", completedAttempts, err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSQLTaskRepositoryRejectsConcurrentDuplicateIdempotencyKeys(t *testing.T) {
|
||||
repository, db := newTaskRepositoryTest(t)
|
||||
defer db.Close()
|
||||
|
||||
ctx := context.Background()
|
||||
start := make(chan struct{})
|
||||
results := make(chan error, 2)
|
||||
for _, taskID := range []string{"task-idempotency-a", "task-idempotency-b"} {
|
||||
go func(taskID string) {
|
||||
<-start
|
||||
results <- repository.CreateTask(ctx, Task{
|
||||
ID: taskID, DomainID: "domain-1", TaskType: "certificate_issue",
|
||||
Status: "queued", Stage: "queued", Message: "test",
|
||||
IdempotencyKey: "duplicate-key-20260929",
|
||||
})
|
||||
}(taskID)
|
||||
}
|
||||
close(start)
|
||||
|
||||
var succeeded, failed int
|
||||
for range 2 {
|
||||
if err := <-results; err == nil {
|
||||
succeeded++
|
||||
} else {
|
||||
failed++
|
||||
}
|
||||
}
|
||||
if succeeded != 1 || failed != 1 {
|
||||
t.Fatalf("unexpected concurrent idempotency result: success=%d failure=%d", succeeded, failed)
|
||||
}
|
||||
|
||||
items, err := repository.ListTasks(ctx, "domain-1", 10)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(items) != 1 || items[0].IdempotencyKey != "duplicate-key-20260929" {
|
||||
t.Fatalf("duplicate idempotency key created multiple tasks: %+v", items)
|
||||
}
|
||||
stored, err := repository.FindTaskByIdempotencyKey(ctx, "domain-1", "duplicate-key-20260929")
|
||||
if err != nil || stored.ID != items[0].ID {
|
||||
t.Fatalf("idempotency lookup mismatch: %+v %v", stored, err)
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user