增加域名 DNS 账户绑定与引用保护并修复并发冲突分类

This commit is contained in:
xuans committed 2026-10-04 05:35:11 +08:00
1 parent 1dc72f2b44
commit 7a6da6b2c9
25 files changed
+966 -24

No files matched your search

@@ -0,0 +1,200 @@
package database
import (
"database/sql"
"fmt"
"testing"
"git.pcux.cn/xuans/Scert/backend/internal/config"
"git.pcux.cn/xuans/Scert/backend/internal/testsupport/mysqltest"
"git.pcux.cn/xuans/Scert/backend/internal/testsupport/postgrestest"
)
func TestDomainDNSAccountMigration(t *testing.T) {
for _, driver := range []string{"sqlite", "mysql", "postgres"} {
t.Run(driver, func(t *testing.T) {
var cfg config.DatabaseConfig
switch driver {
case "sqlite":
cfg = sqliteBusinessUpgradeConfig(t)
case "mysql":
cfg = mysqltest.New(t).Database(t)
case "postgres":
cfg = postgrestest.New(t).Database(t)
}
db, err := Open(t.Context(), cfg)
if err != nil {
t.Fatal(err)
}
defer db.Close()
if _, err := db.DB.ExecContext(t.Context(), migrationTableSQL(driver)); err != nil {
t.Fatal(err)
}
for version := 1; version <= 27; version++ {
if err := applyMigration(t.Context(), db.DB, driver, version); err != nil {
t.Fatal(err)
}
}
seedDomainDNSMigration(t, db.DB)
if err := Migrate(t.Context(), db.DB, driver); err != nil {
t.Fatal(err)
}
checkDomainDNSConstraints(t, db.DB, driver)
if err := Migrate(t.Context(), db.DB, driver); err != nil {
t.Fatal(err)
}
var count int
if err := db.DB.QueryRowContext(t.Context(), `SELECT COUNT(*) FROM domain_dns_accounts WHERE id='binding' AND dns_account_id='account-a'`).Scan(&count); err != nil || count != 1 {
t.Fatal("重入迁移改变已有绑定", err)
}
})
}
}
func TestSQLiteDomainDNSAccountGuards(t *testing.T) {
for _, foreignKeys := range []int{0, 1} {
for _, recursive := range []int{0, 1} {
t.Run(fmt.Sprintf("foreign_keys_%d_recursive_%d", foreignKeys, recursive), func(t *testing.T) {
cfg := sqliteBusinessUpgradeConfig(t)
cfg.MaxOpenConns, cfg.MaxIdleConns = 1, 1
db, err := Open(t.Context(), cfg)
if err != nil {
t.Fatal(err)
}
defer db.Close()
for _, statement := range []string{fmt.Sprintf("PRAGMA foreign_keys=%d", foreignKeys), fmt.Sprintf("PRAGMA recursive_triggers=%d", recursive)} {
if _, err := db.DB.ExecContext(t.Context(), statement); err != nil {
t.Fatal(err)
}
}
if err := Migrate(t.Context(), db.DB, "sqlite"); err != nil {
t.Fatal(err)
}
seedDomainDNSMigration(t, db.DB)
checkDomainDNSConstraints(t, db.DB, "sqlite")
for name, want := range map[string]int{"foreign_keys": foreignKeys, "recursive_triggers": recursive} {
var value int
if err := db.DB.QueryRowContext(t.Context(), "PRAGMA "+name).Scan(&value); err != nil || value != want {
t.Fatal("迁移不应修改连接设置", name, err)
}
}
})
}
}
}
func seedDomainDNSMigration(t *testing.T, db *sql.DB) {
t.Helper()
for _, statement := range []string{
`INSERT INTO projects (id,name,description) VALUES ('binding-other','另一个项目','')`,
`INSERT INTO domains (id,name,certificate_type,sans_json,status,project_id) VALUES ('domain-a','bound.example.test','single','[]','valid','default')`,
`INSERT INTO domains (id,name,certificate_type,sans_json,status,project_id) VALUES ('domain-b','other.example.test','single','[]','valid','binding-other')`,
`INSERT INTO dns_accounts VALUES ('account-a','账户','default','old-owner','cloudflare','secret://dns/account-a','active','verified',8,CURRENT_TIMESTAMP,CURRENT_TIMESTAMP)`,
`INSERT INTO dns_accounts VALUES ('account-b','其他账户','binding-other','old-owner','cloudflare','secret://dns/account-b','active','verified',2,CURRENT_TIMESTAMP,CURRENT_TIMESTAMP)`,
} {
if _, err := db.ExecContext(t.Context(), statement); err != nil {
t.Fatal(err)
}
}
}
func checkDomainDNSConstraints(t *testing.T, db *sql.DB, driver string) {
t.Helper()
if _, err := db.ExecContext(t.Context(), `INSERT INTO domain_dns_accounts VALUES ('domain-a','binding','default','account-a',CURRENT_TIMESTAMP)`); err != nil {
t.Fatal(err)
}
for _, statement := range []string{
`INSERT INTO domain_dns_accounts VALUES ('domain-b','cross-domain','default','account-a',CURRENT_TIMESTAMP)`,
`INSERT INTO domain_dns_accounts VALUES ('domain-b','cross-account','binding-other','account-a',CURRENT_TIMESTAMP)`,
`INSERT INTO domain_dns_accounts VALUES ('missing','orphan','default','account-a',CURRENT_TIMESTAMP)`,
`UPDATE domain_dns_accounts SET dns_account_id='account-b' WHERE id='binding'`,
`UPDATE domain_dns_accounts SET domain_id='domain-b' WHERE id='binding'`,
`UPDATE domain_dns_accounts SET project_id='binding-other' WHERE id='binding'`,
`DELETE FROM dns_accounts WHERE id='account-a'`,
`DELETE FROM domains WHERE id='domain-a'`,
`UPDATE dns_accounts SET id='moved' WHERE id='account-a'`,
`UPDATE dns_accounts SET project_id='binding-other' WHERE id='account-a'`,
`UPDATE domains SET id='moved' WHERE id='domain-a'`,
`UPDATE domains SET project_id='binding-other' WHERE id='domain-a'`,
} {
if _, err := db.ExecContext(t.Context(), statement); err == nil {
t.Fatal("数据库未阻止破坏引用:", statement)
}
}
if driver == "sqlite" {
for _, statement := range []string{
`INSERT OR REPLACE INTO domains (id,name,certificate_type,sans_json,status) VALUES ('domain-a','new.example.test','single','[]','pending')`,
`INSERT OR REPLACE INTO domains (id,name,certificate_type,sans_json,status) VALUES ('new-domain','bound.example.test','single','[]','pending')`,
`INSERT OR REPLACE INTO dns_accounts VALUES ('account-a','替换','default','owner','cloudflare','secret://dns/new','active','verified',1,CURRENT_TIMESTAMP,CURRENT_TIMESTAMP)`,
`INSERT OR REPLACE INTO dns_accounts VALUES ('new-account','替换','default','owner','cloudflare','secret://dns/account-a','active','verified',1,CURRENT_TIMESTAMP,CURRENT_TIMESTAMP)`,
} {
if _, err := db.ExecContext(t.Context(), statement); err == nil {
t.Fatal("替换操作破坏绑定父记录", statement)
}
}
}
var revision int
var status string
if err := db.QueryRowContext(t.Context(), `SELECT revision FROM dns_accounts WHERE id='account-a'`).Scan(&revision); err != nil || revision != 8 {
t.Fatal("约束拒绝改变账户数据", err)
}
if err := db.QueryRowContext(t.Context(), `SELECT status FROM domains WHERE id='domain-a'`).Scan(&status); err != nil || status != "valid" {
t.Fatal("升级或拒绝改变域名状态", err)
}
}
func TestMySQLDomainDNSAccountInterruptedMigration(t *testing.T) {
f := startRealMySQL(t)
for _, boundary := range []string{"before_create", "after_create", "after_index", "after_domain_fk", "after_account_fk", "with_binding", "bad_column", "bad_index", "bad_foreign_key", "extra_foreign_key"} {
t.Run(boundary, func(t *testing.T) {
db := f.database(t)
mysqlPrepareVersion(t, db.DB, 27)
statements := mysqlDeploymentStatements(t, 28)
if boundary != "before_create" {
mysqlDeploymentExec(t, db.DB, statements[0])
}
if boundary == "after_index" || boundary == "after_domain_fk" || boundary == "after_account_fk" || boundary == "with_binding" {
mysqlDeploymentExec(t, db.DB, statements[1])
}
if boundary == "after_domain_fk" || boundary == "after_account_fk" || boundary == "with_binding" {
mysqlDeploymentExec(t, db.DB, statements[2])
}
if boundary == "after_account_fk" || boundary == "with_binding" {
mysqlDeploymentExec(t, db.DB, statements[3])
}
conflict := true
switch boundary {
case "bad_column":
mysqlDeploymentExec(t, db.DB, `ALTER TABLE domain_dns_accounts MODIFY COLUMN id VARCHAR(36) NULL`)
case "bad_index":
mysqlDeploymentExec(t, db.DB, `CREATE INDEX uq_dns_accounts_project_id ON dns_accounts (project_id, id)`)
case "bad_foreign_key":
mysqlDeploymentExec(t, db.DB, `ALTER TABLE domain_dns_accounts ADD CONSTRAINT fk_domain_dns_domain FOREIGN KEY (project_id, domain_id) REFERENCES domains(project_id,id) ON DELETE CASCADE`)
case "extra_foreign_key":
mysqlDeploymentExec(t, db.DB, `ALTER TABLE domain_dns_accounts ADD CONSTRAINT unexpected_domain_dns FOREIGN KEY (project_id) REFERENCES projects(id)`)
default:
conflict = false
}
if boundary == "with_binding" {
seedDomainDNSMigration(t, db.DB)
mysqlDeploymentExec(t, db.DB, `INSERT INTO domain_dns_accounts VALUES ('domain-a','binding','default','account-a',CURRENT_TIMESTAMP)`)
}
for range 2 {
err := Migrate(t.Context(), db.DB, "mysql")
if (err != nil) != conflict {
t.Fatal("中断恢复或冲突判断错误", err)
}
version, err := currentMigrationVersion(t.Context(), db.DB)
if err != nil || (conflict && version != 27) || (!conflict && version != latestMigrationVersion) {
t.Fatal("迁移版本提前登记", version, err)
}
}
if boundary == "with_binding" {
var account string
if err := db.DB.QueryRowContext(t.Context(), `SELECT dns_account_id FROM domain_dns_accounts WHERE id='binding'`).Scan(&account); err != nil || account != "account-a" {
t.Fatal("中断恢复改变原有绑定", err)
}
}
})
}
}
+13 -1
View File
@@ -28,6 +28,7 @@ import (
//go:embed migrations/sqlite/0025_recovery_reconciliation.sql migrations/mysql/0025_recovery_reconciliation.sql migrations/postgres/0025_recovery_reconciliation.sql
//go:embed migrations/sqlite/0026_domain_challenge.sql migrations/mysql/0026_domain_challenge.sql migrations/postgres/0026_domain_challenge.sql
//go:embed migrations/sqlite/0027_dns_accounts.sql migrations/mysql/0027_dns_accounts.sql migrations/postgres/0027_dns_accounts.sql
//go:embed migrations/sqlite/0028_domain_dns_accounts.sql migrations/mysql/0028_domain_dns_accounts.sql migrations/postgres/0028_domain_dns_accounts.sql
var migrationFiles embed.FS
func Migrate(ctx context.Context, db *sql.DB, driver string) error {
@@ -52,7 +53,7 @@ func Migrate(ctx context.Context, db *sql.DB, driver string) error {
return nil
}
const latestMigrationVersion = 27
const latestMigrationVersion = 28
// currentMigrationVersion 在执行业务迁移前拒绝新版数据库及不连续的迁移历史。
func currentMigrationVersion(ctx context.Context, db *sql.DB) (int, error) {
@@ -92,6 +93,9 @@ func applyMigration(ctx context.Context, db *sql.DB, driver string, version int)
return applySQLiteTaskMigration(ctx, db, statements, version)
}
if driver == "mysql" {
if version == 28 {
return applyMySQLDomainDNSMigration(ctx, db, version, statements)
}
if version == 27 {
return applyMySQLDNSAccountMigration(ctx, db, version, statements)
}
@@ -181,6 +185,12 @@ func applyMigration(ctx context.Context, db *sql.DB, driver string, version int)
return err
}
}
if driver == "sqlite" && version == 28 {
if err := installSQLiteDomainDNSConstraints(ctx, tx); err != nil {
_ = tx.Rollback()
return err
}
}
migrationVersionInsert := "INSERT INTO schema_migrations (version) VALUES (?)"
if driver == "postgres" {
migrationVersionInsert = "INSERT INTO schema_migrations (version) VALUES ($1)"
@@ -286,6 +296,8 @@ func migrationName(version int) string {
return "domain_challenge"
case 27:
return "dns_accounts"
case 28:
return "domain_dns_accounts"
default:
return "unknown"
}
@@ -0,0 +1,13 @@
CREATE TABLE domain_dns_accounts (
domain_id VARCHAR(36) NOT NULL PRIMARY KEY,
id VARCHAR(36) NOT NULL,
project_id VARCHAR(36) NOT NULL,
dns_account_id VARCHAR(36) NOT NULL,
updated_at DATETIME NOT NULL,
UNIQUE KEY uq_domain_dns_accounts_id (id),
INDEX idx_domain_dns_accounts_domain (project_id, domain_id),
INDEX idx_domain_dns_accounts_account (project_id, dns_account_id)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;
CREATE UNIQUE INDEX uq_dns_accounts_project_id ON dns_accounts (project_id, id);
ALTER TABLE domain_dns_accounts ADD CONSTRAINT fk_domain_dns_domain FOREIGN KEY (project_id, domain_id) REFERENCES domains (project_id, id) ON DELETE RESTRICT;
ALTER TABLE domain_dns_accounts ADD CONSTRAINT fk_domain_dns_account FOREIGN KEY (project_id, dns_account_id) REFERENCES dns_accounts (project_id, id) ON DELETE RESTRICT;
@@ -0,0 +1,11 @@
CREATE UNIQUE INDEX uq_dns_accounts_project_id ON dns_accounts (project_id, id);
CREATE TABLE domain_dns_accounts (
domain_id TEXT NOT NULL PRIMARY KEY,
id TEXT NOT NULL UNIQUE,
project_id TEXT NOT NULL,
dns_account_id TEXT NOT NULL,
updated_at TIMESTAMPTZ NOT NULL,
FOREIGN KEY (project_id, domain_id) REFERENCES domains(project_id, id) ON DELETE RESTRICT,
FOREIGN KEY (project_id, dns_account_id) REFERENCES dns_accounts(project_id, id) ON DELETE RESTRICT
);
CREATE INDEX idx_domain_dns_accounts_account ON domain_dns_accounts (project_id, dns_account_id);
@@ -0,0 +1,11 @@
CREATE UNIQUE INDEX uq_dns_accounts_project_id ON dns_accounts (project_id, id);
CREATE TABLE domain_dns_accounts (
domain_id TEXT NOT NULL PRIMARY KEY,
id TEXT NOT NULL UNIQUE,
project_id TEXT NOT NULL,
dns_account_id TEXT NOT NULL,
updated_at DATETIME NOT NULL,
FOREIGN KEY (project_id, domain_id) REFERENCES domains(project_id, id) ON DELETE RESTRICT,
FOREIGN KEY (project_id, dns_account_id) REFERENCES dns_accounts(project_id, id) ON DELETE RESTRICT
);
CREATE INDEX idx_domain_dns_accounts_account ON domain_dns_accounts (project_id, dns_account_id);
@@ -8,7 +8,7 @@ import (
)
func TestMySQLDeploymentShapeDefinitions(t *testing.T) {
for _, version := range []int{15, 16, 17, 20, 21, 22, 23, 24, 27} {
for _, version := range []int{15, 16, 17, 20, 21, 22, 23, 24, 27, 28} {
statements := mysqlDeploymentStatements(t, version)
shape, err := parseMySQLDeploymentShape(statements[0])
if err != nil || len(shape.Columns) == 0 || len(shape.Indexes) == 0 {
@@ -0,0 +1,115 @@
package database
import (
"context"
"database/sql"
"fmt"
"strings"
)
// MySQL DDL 不支持事务回滚,每一步重入均检查真实结构;不覆盖冲突表或外键。
func applyMySQLDomainDNSMigration(ctx context.Context, db *sql.DB, version int, statements []string) error {
if len(statements) != 4 {
return fmt.Errorf("域名 DNS 绑定迁移不完整")
}
shape, err := parseMySQLDeploymentShape(statements[0])
if err != nil {
return err
}
if _, err := db.ExecContext(ctx, strings.Replace(statements[0], "CREATE TABLE ", "CREATE TABLE IF NOT EXISTS ", 1)); err != nil {
return err
}
if err := validateMySQLDeploymentShape(ctx, db, shape); err != nil {
return err
}
var indexCount int
if err := db.QueryRowContext(ctx, `SELECT COUNT(*) FROM information_schema.statistics
WHERE table_schema = DATABASE() AND table_name = 'dns_accounts' AND index_name = 'uq_dns_accounts_project_id'`).Scan(&indexCount); err != nil {
return err
}
if indexCount == 0 {
if _, err := db.ExecContext(ctx, statements[1]); err != nil {
return err
}
indexCount = 2
}
var validIndex int
if err := db.QueryRowContext(ctx, `SELECT COUNT(*) FROM information_schema.statistics
WHERE table_schema = DATABASE() AND table_name = 'dns_accounts' AND index_name = 'uq_dns_accounts_project_id'
AND non_unique = 0 AND sub_part IS NULL AND index_type = 'BTREE' AND is_visible = 'YES'
AND ((seq_in_index = 1 AND column_name = 'project_id') OR (seq_in_index = 2 AND column_name = 'id'))`).Scan(&validIndex); err != nil {
return err
}
if indexCount != 2 || validIndex != 2 {
return fmt.Errorf("DNS 账户项目唯一索引不符合预期")
}
existing, err := validateMySQLDomainDNSForeignKeys(ctx, db)
if err != nil {
return err
}
for i, name := range []string{"fk_domain_dns_domain", "fk_domain_dns_account"} {
if !existing[name] {
if _, err := db.ExecContext(ctx, statements[i+2]); err != nil {
return err
}
}
}
existing, err = validateMySQLDomainDNSForeignKeys(ctx, db)
if err != nil {
return err
}
if len(existing) != 2 {
return fmt.Errorf("域名 DNS 绑定外键不完整")
}
_, err = db.ExecContext(ctx, "INSERT INTO schema_migrations (version) VALUES (?)", version)
return err
}
func validateMySQLDomainDNSForeignKeys(ctx context.Context, db *sql.DB) (map[string]bool, error) {
rows, err := db.QueryContext(ctx, `SELECT r.constraint_name, r.delete_rule, r.update_rule,
k.column_name, k.referenced_table_schema, k.referenced_table_name, k.referenced_column_name,
k.ordinal_position, DATABASE()
FROM information_schema.referential_constraints r JOIN information_schema.key_column_usage k
ON k.constraint_schema = r.constraint_schema AND k.table_name = r.table_name AND k.constraint_name = r.constraint_name
WHERE r.constraint_schema = DATABASE() AND r.table_name = 'domain_dns_accounts'`)
if err != nil {
return nil, err
}
defer rows.Close()
positions := make(map[string]map[int]bool)
for rows.Next() {
var name, onDelete, onUpdate, column, schema, table, target, currentSchema string
var position int
if err := rows.Scan(&name, &onDelete, &onUpdate, &column, &schema, &table, &target, &position, &currentSchema); err != nil {
return nil, err
}
expectedTable, expectedColumn := "domains", "domain_id"
if name == "fk_domain_dns_account" {
expectedTable, expectedColumn = "dns_accounts", "dns_account_id"
} else if name != "fk_domain_dns_domain" {
return nil, fmt.Errorf("域名 DNS 绑定包含未知外键")
}
validColumn := position == 1 && column == "project_id" && target == "project_id" || position == 2 && column == expectedColumn && target == "id"
if !validColumn || table != expectedTable || schema != currentSchema || onDelete != "RESTRICT" || (onUpdate != "RESTRICT" && onUpdate != "NO ACTION") {
return nil, fmt.Errorf("域名 DNS 绑定外键与预期不一致")
}
if positions[name] == nil {
positions[name] = make(map[int]bool)
}
if positions[name][position] {
return nil, fmt.Errorf("域名 DNS 绑定外键列重复")
}
positions[name][position] = true
}
if err := rows.Err(); err != nil {
return nil, err
}
result := make(map[string]bool)
for name, columns := range positions {
if len(columns) != 2 {
return nil, fmt.Errorf("域名 DNS 绑定外键列不完整")
}
result[name] = true
}
return result, nil
}
@@ -0,0 +1,43 @@
package database
import (
"context"
"database/sql"
"fmt"
)
// 即使用户关闭外键或递归触发器,仍阻止跨项目绑定和父记录替换造成悬空引用。
func installSQLiteDomainDNSConstraints(ctx context.Context, tx *sql.Tx) error {
for _, operation := range []string{"INSERT", "UPDATE"} {
statement := fmt.Sprintf(`CREATE TRIGGER scert_domain_dns_%s BEFORE %s ON domain_dns_accounts
WHEN NOT EXISTS (SELECT 1 FROM domains WHERE id = NEW.domain_id AND project_id = NEW.project_id)
OR NOT EXISTS (SELECT 1 FROM dns_accounts WHERE id = NEW.dns_account_id AND project_id = NEW.project_id)
BEGIN SELECT RAISE(ABORT, 'domain DNS project mismatch'); END`, operation, operation)
if _, err := tx.ExecContext(ctx, statement); err != nil {
return err
}
}
for _, parent := range []struct{ table, column, unique string }{
{"domains", "domain_id", "name"}, {"dns_accounts", "dns_account_id", "credential_ref"},
} {
statements := []string{
fmt.Sprintf(`CREATE TRIGGER scert_domain_dns_%s_delete BEFORE DELETE ON %s
WHEN EXISTS (SELECT 1 FROM domain_dns_accounts WHERE %s = OLD.id)
BEGIN SELECT RAISE(ABORT, 'domain DNS reference exists'); END`, parent.table, parent.table, parent.column),
fmt.Sprintf(`CREATE TRIGGER scert_domain_dns_%s_update BEFORE UPDATE OF id, project_id ON %s
WHEN (NEW.id <> OLD.id OR NEW.project_id <> OLD.project_id)
AND EXISTS (SELECT 1 FROM domain_dns_accounts WHERE %s = OLD.id)
BEGIN SELECT RAISE(ABORT, 'domain DNS reference exists'); END`, parent.table, parent.table, parent.column),
fmt.Sprintf(`CREATE TRIGGER scert_domain_dns_%s_replace BEFORE INSERT ON %s
WHEN EXISTS (SELECT 1 FROM domain_dns_accounts binding JOIN %s parent ON parent.id = binding.%s
WHERE parent.id = NEW.id OR parent.%s = NEW.%s)
BEGIN SELECT RAISE(ABORT, 'domain DNS replacement denied'); END`, parent.table, parent.table, parent.table, parent.column, parent.unique, parent.unique),
}
for _, statement := range statements {
if _, err := tx.ExecContext(ctx, statement); err != nil {
return err
}
}
}
return nil
}