检查点:保存数据库回归修复候选并继续核查引擎与实库阻塞

This commit is contained in:
xuans committed 2026-09-28 18:11:58 +08:00
1 parent b11ee746fe
commit 0edde01e4b
4 files changed
+143 -16

No files matched your search

@@ -2,8 +2,11 @@ package database
import (
"database/sql"
"errors"
"strings"
"testing"
"github.com/go-sql-driver/mysql"
)
func seedHistoryScope(t *testing.T, db *sql.DB, driver string) {
@@ -202,10 +205,17 @@ func TestHistoryScopeMySQLMigrationRetry(t *testing.T) {
}
if err := Migrate(ctx, db.DB, "mysql"); err == nil {
t.Fatal("故障未阻断迁移")
} else {
var mysqlErr *mysql.MySQLError
// 必须命中注入阶段,不能把索引损坏等其他错误误当作故障注入成功。
if !errors.As(err, &mysqlErr) || mysqlErr.Number != 1644 || mysqlErr.Message != "test-only" {
t.Fatalf("迁移在注入阶段 %s 之前意外失败,保留服务器日志供诊断:%v", phase, err)
}
}
if version, err := currentMigrationVersion(ctx, db.DB); err != nil || version != 12 {
t.Fatalf("失败版本错误:%d,%v", version, err)
}
assertMySQLHistoryIndexes(t, db.DB)
if _, err := fixture.admin.ExecContext(ctx, "DROP TRIGGER "+schema+".fail_history"); err != nil {
t.Fatal(err)
}
@@ -213,6 +223,7 @@ func TestHistoryScopeMySQLMigrationRetry(t *testing.T) {
if err := Migrate(ctx, db.DB, "mysql"); err != nil {
t.Fatal(err)
}
assertMySQLHistoryIndexes(t, db.DB)
}
assertHistoryScope(t, db.DB)
if version, err := currentMigrationVersion(ctx, db.DB); err != nil || version != latestMigrationVersion {
@@ -221,3 +232,20 @@ func TestHistoryScopeMySQLMigrationRetry(t *testing.T) {
})
}
}
func assertMySQLHistoryIndexes(t *testing.T, db *sql.DB) {
t.Helper()
for _, index := range []struct{ table, name, columns string }{
{"tasks", "idx_tasks_project_history", "project_id,created_at"},
{"audit_logs", "idx_audit_project_history", "project_id,created_at"},
{"audit_logs", "idx_audit_task_history", "task_id"},
} {
var columns sql.NullString
err := db.QueryRowContext(t.Context(), `SELECT GROUP_CONCAT(column_name ORDER BY seq_in_index)
FROM information_schema.statistics WHERE table_schema=DATABASE() AND table_name=? AND index_name=?`,
index.table, index.name).Scan(&columns)
if err != nil || !columns.Valid || columns.String != index.columns {
t.Fatalf("历史范围索引结构不完整:%s.%s,字段=%s,错误=%v", index.table, index.name, columns.String, err)
}
}
}
@@ -0,0 +1,97 @@
package database
import (
"context"
"database/sql"
"errors"
"os"
"path/filepath"
"runtime"
"testing"
"time"
"git.pcux.cn/xuans/Scert/backend/internal/config"
)
// 取消可能与驱动返回结果集同时发生;调用方拿不到结果集时也不能遗留读锁和文件句柄。
func TestSQLiteCanceledQueriesReleaseFiles(t *testing.T) {
for _, prepared := range []bool{false, true} {
name := "direct"
if prepared {
name = "prepared"
}
t.Run(name, func(t *testing.T) {
cfg := config.Default(t.TempDir()).Database
cfg.MaxOpenConns, cfg.MaxIdleConns = 1, 1
db, err := Open(t.Context(), cfg)
if err != nil {
t.Fatal(err)
}
t.Cleanup(func() { _ = db.Close() })
if _, err := db.DB.ExecContext(t.Context(), `CREATE TABLE close_probe (id INTEGER PRIMARY KEY);
WITH RECURSIVE values_to_insert(n) AS (SELECT 1 UNION ALL SELECT n+1 FROM values_to_insert WHERE n<128)
INSERT INTO close_probe SELECT n FROM values_to_insert`); err != nil {
t.Fatal(err)
}
query := func(ctx context.Context) (*sql.Rows, error) {
return db.DB.QueryContext(ctx, "SELECT id FROM close_probe")
}
if prepared {
stmt, err := db.DB.PrepareContext(t.Context(), "SELECT id FROM close_probe")
if err != nil {
t.Fatal(err)
}
defer stmt.Close()
query = func(ctx context.Context) (*sql.Rows, error) { return stmt.QueryContext(ctx) }
}
canceled := 0
for attempt := 0; attempt < 2048; attempt++ {
ctx, cancel := context.WithCancel(t.Context())
done := make(chan struct{})
go func() {
// 交替让查询与取消先取得调度,不通过休眠或重试关闭来掩盖泄漏。
for yield := 0; yield < attempt%8; yield++ {
runtime.Gosched()
}
cancel()
close(done)
}()
rows, err := query(ctx)
if rows != nil {
for rows.Next() {
var value int
if scanErr := rows.Scan(&value); scanErr != nil {
err = scanErr
break
}
}
err = errors.Join(err, rows.Err(), rows.Close())
}
<-done
cancel()
if errors.Is(err, context.Canceled) {
canceled++
} else if err != nil {
t.Fatal(err)
}
}
if canceled == 0 {
t.Fatal("没有实际覆盖取消中的查询")
}
// 跨平台检查已取消查询没有留下读事务;关闭后 Windows 还必须立即允许移动文件。
ctx, cancel := context.WithTimeout(t.Context(), time.Second)
defer cancel()
var busy, logFrames, checkpointed int
if err := db.DB.QueryRowContext(ctx, "PRAGMA wal_checkpoint(TRUNCATE)").Scan(&busy, &logFrames, &checkpointed); err != nil || busy != 0 {
t.Fatalf("查询结束后仍存在未释放的读事务:busy=%d,错误=%v", busy, err)
}
if err := db.Close(); err != nil {
t.Fatal(err)
}
if err := os.Rename(cfg.DSN, filepath.Join(filepath.Dir(cfg.DSN), "closed.db")); err != nil {
t.Fatalf("关闭后数据库文件仍被占用:%v", err)
}
t.Logf("已验证 %d 次查询,其中 %d 次实际取消", 2048, canceled)
})
}
}