修复权限失效放行并加固证书推送事务和超时回滚
This commit is contained in:
1 parent
d74f74b631
commit
05e05a1a23
15 files changed
+861
-178
No files matched your search
@@ -77,3 +77,26 @@ func TestSetupRejectsUnauthorizedDomainBeforeIssuer(t *testing.T) {
|
||||
t.Fatalf("初始化证书申请未拒绝未授权域名:%v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestAliyunMissingAuthorizationCheckerBlocksIssueAndSetup(t *testing.T) {
|
||||
cfg := certificateTestConfig(t.TempDir())
|
||||
cfg.DNS.Provider = "aliyun"
|
||||
item, err := domain.NewDomainWithOptions("example.com", domain.CertificateSingle, nil, false, "staging", "aliyun")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
provider := &recordingProviderFactory{}
|
||||
service := NewService(cfg, &serviceRepository{item: item}, serviceCredentials{}, provider, serviceAccounts{})
|
||||
if _, err := service.Issue(t.Context(), item.ID); err == nil || !strings.Contains(err.Error(), "探测器未初始化") {
|
||||
t.Fatalf("缺失检查器必须阻止签发:%v", err)
|
||||
}
|
||||
if _, err := service.IssueForSetup(t.Context(), SetupCertificateRequest{
|
||||
Domains: []string{"example.com"}, CertificateType: "single", ProviderID: "aliyun",
|
||||
CredentialRef: cfg.DNS.CredentialRef, Environment: "staging",
|
||||
}); err == nil || !strings.Contains(err.Error(), "探测器未初始化") {
|
||||
t.Fatalf("缺失检查器必须阻止初始化证书签发:%v", err)
|
||||
}
|
||||
if provider.providerID != "" {
|
||||
t.Fatal("缺失检查器时不得创建 DNS 挑战 Provider")
|
||||
}
|
||||
}
|
||||
@@ -12,6 +12,7 @@ import (
|
||||
"github.com/go-acme/lego/v5/challenge"
|
||||
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/config"
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/dnsprovider"
|
||||
"git.pcux.cn/xuans/Scert/backend/internal/domain"
|
||||
)
|
||||
|
||||
@@ -270,6 +271,9 @@ func (s *Service) IssueForSetup(ctx context.Context, request SetupCertificateReq
|
||||
|
||||
func (s *Service) verifyDNSAuthorization(ctx context.Context, providerID string, domains []string, credentials map[string]string) error {
|
||||
if s == nil || s.authorization == nil {
|
||||
if strings.EqualFold(strings.TrimSpace(providerID), dnsprovider.Aliyun) {
|
||||
return errors.New("阿里云权限探测器未初始化,已阻止证书申请")
|
||||
}
|
||||
return nil
|
||||
}
|
||||
for _, requestedDomain := range domains {
|
||||
|
||||
Reference in new issue
Block a user